diff options
| author | Pekka Paalanen <pekka.paalanen@collabora.co.uk> | 2018-07-03 13:32:00 +0300 |
|---|---|---|
| committer | Derek Foreman <derek.foreman.samsung@gmail.com> | 2018-07-13 11:17:35 -0500 |
| commit | b5f97895da4aae4ba87ae3aa7da36abb86dcb58c (patch) | |
| tree | 43da3d26727ad5355b4a6a57d6c236b7536aaf3a /CONTRIBUTING.md | |
| parent | client: remove definition of wl_global (diff) | |
| download | wayland-b5f97895da4aae4ba87ae3aa7da36abb86dcb58c.tar wayland-b5f97895da4aae4ba87ae3aa7da36abb86dcb58c.tar.gz wayland-b5f97895da4aae4ba87ae3aa7da36abb86dcb58c.tar.bz2 wayland-b5f97895da4aae4ba87ae3aa7da36abb86dcb58c.tar.lz wayland-b5f97895da4aae4ba87ae3aa7da36abb86dcb58c.tar.xz wayland-b5f97895da4aae4ba87ae3aa7da36abb86dcb58c.tar.zst wayland-b5f97895da4aae4ba87ae3aa7da36abb86dcb58c.zip | |
contributing: how to read the review rules
This is to avoid fighting around the letter of the guidelines. This is
not a protocol spec.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Derek Foreman <derek.foreman.samsung@gmail.com>
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 70d0eca..538613f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -206,6 +206,11 @@ people with commit access, there needs to be at least one Acked-by from someone with commit access. A person with commit access is expected to be able to evaluate the patch with respect to the project scope and architecture. +The below review guidelines are intended to be interpreted in spirit, not by +the letter. There may be circumstances where some guidelines are better +ignored. We rely very much on the judgement of reviewers and commit rights +holders. + During review, the following matters should be checked: - The commit message explains why the change is being made. |