feat!: align standard captures with upstream

Problem: Sharing highlight queries with upstream tree-sitter and
Helix is difficult.

Solution: Where reasonable, use capture names in tree-sitter's standard
list or Helix's Atom-style hierarchy.

Specifically:

* tree-sitter "standard capture names"
  (https://github.com/tree-sitter/tree-sitter/blob/3f44b896852eb7daaa6df4fb778c9bb52c70c815/highlight/src/lib.rs#L20-L72):

  - `@parameter` -> `@variable.parameter`
  - `@field` -> `@variable.member`
  - `@namespace` -> `@module`
  - `@float` -> `@number.float`
  - `@symbol` -> `@string.special.symbol`
  - `@string.regex` -> `@string.regexp`
  - `@text.*` -> `@markup.*` (`strong`, `italic`, `link`, `strikethrough`; with exceptions; see below)
  - `@text.title` -> `@markup.heading`
  - `@text.literal` -> `@markup.raw`
  - `@text.reference` -> `@markup.link`
  - `@text.uri` -> `@markup.link.url` (in markup links)
  - `@string.special` -> `@markup.link.label` (non-url links)
  - `@punctuation.special` -> `@markup.list` (markdown lists only; move subitems from `@text.todo`)

* Helix captures
  (https://docs.helix-editor.com/master/themes.html#syntax-highlighting):

  - `@method` -> `@function.method`
  - `@method.call` -> `@function.method.call`
  - `@text.{todo,warning,note,danger}` -> `@comment.{error,warning,hint,info,todo}`
  - `@text.diff.{add,delete,}` -> `@diff.{plus,minus,delta}`
  - `@text.uri` -> `@string.special.url` (outside markup)
  - `@preproc` -> `@keyword.directive`
  - `@define` -> `@keyword.directive`(`.define`?)
  - `@storageclass` -> `@keyword.storage`
  - `@conditional` -> `@keyword.conditional`
  - `@debug` -> `@keyword.debug`
  - `@exception` -> `@keyword.exception`
  - `@include` -> `@keyword.import`
  - `@repeat` -> `@keyword.repeat`

* cleanup

  - remove some redundant `@conceal` (but still allow it for conceal-only patterns)
  - remove obsolete `@error` (syntax linting is out of scope for this repo)
  - sort, cleanup capture list in `CONTRIBUTING.md`

1 files changed, 10 insertions, 10 deletions

diff --git a/queries/dart/highlights.scm b/queries/dart/highlights.scm
index 3ebdae0ea..be2824da5 100644
--- a/queries/dart/highlights.scm
+++ b/queries/dart/highlights.scm
@@ -84,11 +84,11 @@
 (scoped_identifier
   scope: (identifier) @type)
 (function_signature
-  name: (identifier) @method)
+  name: (identifier) @function.method)
 (getter_signature
-  (identifier) @method)
+  (identifier) @function.method)
 (setter_signature
-  name: (identifier) @method)
+  name: (identifier) @function.method)
 (enum_declaration
   name: (identifier) @type)
 (enum_constant
@@ -131,10 +131,10 @@
 ; Parameters
 ; --------------------
 (formal_parameter
-    name: (identifier) @parameter)
+    name: (identifier) @variable.parameter)
 
 (named_argument
-  (label (identifier) @parameter))
+  (label (identifier) @variable.parameter))
 
 ; Literals
 ; --------------------
@@ -147,7 +147,7 @@
     ; (hex_floating_point_literal)
 ] @number
 
-(symbol_literal) @symbol
+(symbol_literal) @string.special.symbol
 (string_literal) @string
 (true) @boolean
 (false) @boolean
@@ -165,7 +165,7 @@
   "as"
   "show"
   "hide"
-] @include
+] @keyword.import
 
 ; Reserved words (cannot be used as identifiers)
 [
@@ -257,7 +257,7 @@
           "static"
           "typedef"))
 
-["if" "else" "switch" "default"] @conditional
+["if" "else" "switch" "default"] @keyword.conditional
 
 [
   "try"
@@ -265,6 +265,6 @@
   "catch"
   "finally"
   (break_statement)
-] @exception
+] @keyword.exception
 
-["do" "while" "continue" "for"] @repeat
+["do" "while" "continue" "for"] @keyword.repeat