| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
| |
The former is deprecated in neovim 0.10. Remove the check added in
9b89ba5f158f73779cd58d0bb2783dfb40b28b0e.
See: https://github.com/neovim/neovim/blob/v0.10.0/runtime/doc/deprecated.txt#L55
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem:
`:checkhealth lspconfig` fails:
E5009: Invalid $VIMRUNTIME: .../share/nvim/runtime
Error executing lua: Vim:E21: Cannot make changes, 'modifiable' is off
stack traceback:
[C]: in function 'append'
.../share/nvim/runtime/lua/vim/health.lua:443: in function '_check'
`:checkhealth` cannot call itself recursively. And even if it did work,
it would show a duplicate report since `:checkhealth vim.lsp` will also
be part of the report.
Solution:
On Nvim 0.11,
- show a deprecation message if invoked directly.
- show a softer message if invoked as part of the "full report".
fix #3664
|
| |
|
|
|
|
|
|
|
| |
Problem:
`:checkhealth lspconfig` has no benefits vs `:checkhealth vim.lsp`.
Solution:
- on Nvim 0.11+, `:LspInfo` is an alias to `:checkhealth vim.lsp`
instead of `:checkhealth lspconfig`.
- `lua/lspconfig/health.lua` will be removed in a few months.
|
| |
|
|
|
|
|
|
|
|
|
| |
Problem:
LspInfo returns '?' for version string when using the codeqlls
language server. This is because codeql is slow to return its
version number due to the underlying JVM.
Solution:
Increase the timeout from 300ms to 500ms.
1000 iterations of `codeql version` resulted in (349 +- 13) ms
which informed the choice of 500ms.
|
| |
|
|
|
|
|
|
| |
This reverts commit e118ce58dab72c17216292eef7df4cee3cf60885.
It turns out `util.available_servers` is used more than anticipated, so
we revert the privatization for the time being.
Closes https://github.com/neovim/nvim-lspconfig/issues/3588
|
| |
|
|
| |
Work on https://github.com/neovim/nvim-lspconfig/issues/2079.
|
| |
|
|
|
| |
Lspconfig requires neovim version 0.9 at the time of writing this, so
discard any version checks and code for older versions.
|
| |
|
|
|
| |
We still support neovim 0.9 currently, so we can't use vim.uv. Also add
a check so we don't accidentally reintroduce it.
|
| | |
|
| |
|
|
|
|
|
| |
Problem:
"root directory" not reported.
Solution:
report root_dir. regression from b55b9659de9ac17e05df4787bb023e4c7ef45329
|
| |
|
|
|
|
|
|
|
|
| |
Problem:
version fails for jdtls
Solution:
Try `-version` (one hyphen). Drop `-v`, it's probably not useful. Also
drop `-h` because it is unlikely to work if `--help` didn't work.
TODO: make a smarter guess about the actual "argv0" of `cmd`.
|
| |
|
|
|
|
|
|
|
|
| |
Problem:
`cmd` may be a random function instead of an executable command.
ERROR Failed to run healthcheck for "lspconfig" plugin. Exception:
.../lua/lspconfig/health.lua:127: attempt to index field 'cmd' (a function value)
Solution:
Skip attempt to invoke `<cmd> --version` if `cmd` is a function.
|
| |
|
|
|
|
| |
- try the next command if:
- version pattern is not matched
- exitcode is nonzero or timeout.
- truncate long output
|
| | |
|
| |
|
|
|
|
|
| |
- improve version handling: try --version, -v, etc.
- avoid hanging commands (timeout after 1s).
- also collect stderr.
- show "Tried: ..." on failure.
- omit "custom handlers" if none found.
|
| |
|
|
|
|
|
| |
Problem:
version is only printed for make_config_info.
Solution:
Add it to make_client_info.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem:
`config.lspinfo` is an undocumented feature that allows extending the
info shown in `:LspInfo` (`:checkhealth lspconfig`).
This feature is unwanted because:
- it's undocumented
- it adds a maintenance burden
- it provides info that should be derived from the LSP protocol itself.
Solution:
Remove support for `config.lspinfo`.
Instead, `:LspInfo` (`:checkhealth lspconfig`) should be enhanced to
automatically gather this kind of extra info from the server response.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Problem:
Root directory is always reported as "Running in single file mode".
Solution:
Don't prettify the filepath until "presenting" it.
fix #3346
|
| |
|
|
| |
fix #3342
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Problem:
:LspInfo has its own "inner platlform" of highlights, mappings etc. And
it doesn't integrate with :checkhealth.
Solution:
- Move the lspinfo code to a healthcheck.
- LspInfo features such as highlights, "floating window" presentation,
etc., should be added to :checkhealth in Nvim core, if they are really
needed.
- Define a "q" mapping until Nvim stable has that in :checkhealth.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, lspconfig had a recommended healthcheck. This was mostly
noise as its predominant use was to check if a server was installed.
This check was not accurate as vim.fn.executable is extremely primitive
and does not consider cmd_env (forwarded to uv_spawn) or language servers
that are run via an interpreter.
Furthermore, checking if a language server is executable will no longer
be a useful signal once TCP support (which allows for connecting to
already running or remote servers).
Remove for now.
|
| | |
|
| | |
|
| |
|
| |
Co-authored-by: erw7 <erw7.github@gmail.com>
|
| |
|
| |
as mandated by https://github.com/neovim/neovim/pull/15259#issuecomment-934241413
|
| | |
|
| | |
|
| | |
|
| |
|
