fix: ":checkhealth lspconfig" fails on Nvim 0.11 #3668

Problem:
`:checkhealth lspconfig` fails:

    E5009: Invalid $VIMRUNTIME: .../share/nvim/runtime
    Error executing lua: Vim:E21: Cannot make changes, 'modifiable' is off
    stack traceback:
            [C]: in function 'append'
            .../share/nvim/runtime/lua/vim/health.lua:443: in function '_check'

`:checkhealth` cannot call itself recursively. And even if it did work,
it would show a duplicate report since `:checkhealth vim.lsp` will also
be part of the report.

Solution:
On Nvim 0.11,
- show a deprecation message if invoked directly.
- show a softer message if invoked as part of the "full report".

fix #3664

1 files changed, 10 insertions, 2 deletions

diff --git a/lua/lspconfig/health.lua b/lua/lspconfig/health.lua
index 02326c84..5ef54283 100644
--- a/lua/lspconfig/health.lua
+++ b/lua/lspconfig/health.lua
@@ -324,8 +324,16 @@ end
 
 function M.check()
   if vim.fn.has('nvim-0.11') == 1 then
-    vim.deprecate(':checkhealth lspconfig', ':checkhealth vim.lsp', '0.12', 'nvim-lspconfig', false)
-    vim.cmd [[checkhealth vim.lsp]]
+    local bufempty = vim.fn.line('$') < 3
+    if bufempty then
+      -- Infer that `:checkhealth lspconfig` was called directly.
+      health.info('`:checkhealth lspconfig` was removed. Use `:checkhealth vim.lsp` instead.')
+      vim.deprecate(':checkhealth lspconfig', ':checkhealth vim.lsp', '0.12', 'nvim-lspconfig', false)
+    else
+      -- Healthcheck was auto-discovered  by `:checkhealth` (no args).
+      health.info('Skipped. This healthcheck is redundant with `:checkhealth vim.lsp`.')
+    end
+
     return
   end