diff options
| author | David <12832280+David-Else@users.noreply.github.com> | 2022-05-30 23:08:07 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-30 15:08:07 -0700 |
| commit | 66a6c656b65284b889f78bee490d2f31cf7060fe (patch) | |
| tree | 8c6c704d49097c06bcaa582c3e1b714426869463 /lua | |
| parent | fix: buffer may be invalid during on_attach #1822 (diff) | |
| download | nvim-lspconfig-66a6c656b65284b889f78bee490d2f31cf7060fe.tar nvim-lspconfig-66a6c656b65284b889f78bee490d2f31cf7060fe.tar.gz nvim-lspconfig-66a6c656b65284b889f78bee490d2f31cf7060fe.tar.bz2 nvim-lspconfig-66a6c656b65284b889f78bee490d2f31cf7060fe.tar.lz nvim-lspconfig-66a6c656b65284b889f78bee490d2f31cf7060fe.tar.xz nvim-lspconfig-66a6c656b65284b889f78bee490d2f31cf7060fe.tar.zst nvim-lspconfig-66a6c656b65284b889f78bee490d2f31cf7060fe.zip | |
fix(denols): update settings for lint and tsconfig #1933
- Linting is now enabled by default https://deno.com/blog/v1.22#linting-enabled-by-default-in-the-lsp
so it should not be turned off in these settings
- `tsconfig` is an outdated way to make any config changes in Deno and should not be used:
https://deno.land/manual/typescript/configuration#configuring-typescript-in-deno
> ⚠️ Deno v1.14 started supporting a more general configuration file that is no
> longer confined to specifying TypeScript compiler settings. Using
> tsconfig.json as a file name will still work, but we recommend to use
> deno.json or deno.jsonc
@jason0x43 agreed in the previous thread:
https://github.com/neovim/nvim-lspconfig/pull/1321#issuecomment-1024191242
> Currently, deno only looks for deno.json, deno.jsonc, tsconfig.json, or .git
> to determine the root. I think dropping tsconfig.json makes sense because Deno
> now has it's own preferred config file name. Having .git seems reasonable
> enough because projects will often be in git repos. I could even see enabling
> single_file mode by default for the Deno LS since making simple CLI tools is
> (theoretically) a standard use case.
If this pull request is accepted then the docs can also be simplified:
https://deno.land/manual/getting_started/setup_your_environment#neovim-06-and-nvim-lspconfig
Diffstat (limited to 'lua')
| -rw-r--r-- | lua/lspconfig/server_configurations/denols.lua | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/lua/lspconfig/server_configurations/denols.lua b/lua/lspconfig/server_configurations/denols.lua index a7bed35f..00388e09 100644 --- a/lua/lspconfig/server_configurations/denols.lua +++ b/lua/lspconfig/server_configurations/denols.lua @@ -72,10 +72,9 @@ return { 'typescriptreact', 'typescript.tsx', }, - root_dir = util.root_pattern('deno.json', 'deno.jsonc', 'tsconfig.json', '.git'), + root_dir = util.root_pattern('deno.json', 'deno.jsonc', '.git'), init_options = { enable = true, - lint = false, unstable = false, }, handlers = { @@ -106,9 +105,9 @@ vim.g.markdown_fenced_languages = { } ``` -]], +]] , default_config = { - root_dir = [[root_pattern("deno.json", "deno.jsonc", "tsconfig.json", ".git")]], + root_dir = [[root_pattern("deno.json", "deno.jsonc", ".git")]], }, }, } |
