refactor(powershell): remove .script and fix fast API error (#1057)

Calling vim.fn.executable in the module scope has potential to error
if the module is required outside of the main loop.

1 files changed, 2 insertions, 46 deletions

diff --git a/tests/mason-core/managers/powershell_spec.lua b/tests/mason-core/managers/powershell_spec.lua
index e82a18e0..46e096bf 100644
--- a/tests/mason-core/managers/powershell_spec.lua
+++ b/tests/mason-core/managers/powershell_spec.lua
@@ -3,6 +3,7 @@ local spy = require "luassert.spy"
 local match = require "luassert.match"
 local mock = require "luassert.mock"
 local spawn = require "mason-core.spawn"
+local a = require "mason-core.async"
 
 describe("powershell manager", function()
     local function powershell()
@@ -48,52 +49,6 @@ describe("powershell manager", function()
         assert.spy(custom_spawn.pwsh).was_called(1)
     end)
 
-    it("should use the provided spawner scripts", function()
-        spy.on(spawn, "pwsh")
-        local custom_spawn = mock.new { pwsh = mockx.just_runs }
-        stub(vim.fn, "executable")
-        vim.fn.executable.on_call_with("pwsh").returns(1)
-        powershell().script("echo 'Is this bash?'", {}, custom_spawn)
-
-        assert.spy(spawn.pwsh).was_called(0)
-        assert.spy(custom_spawn.pwsh).was_called(1)
-    end)
-
-    it("should provide default powershell options via script stdin", function()
-        local stdin = mock.new {}
-        stub(spawn, "pwsh", function(args)
-            args.on_spawn(nil, { stdin })
-        end)
-        stub(vim.fn, "executable")
-        stub(vim.loop, "write", function(_, _, callback)
-            callback()
-        end)
-        stub(vim.loop, "shutdown", function(_, callback)
-            callback()
-        end)
-        vim.fn.executable.on_call_with("pwsh").returns(1)
-
-        powershell().script "echo 'Is this bash?'"
-
-        assert.spy(spawn.pwsh).was_called(1)
-        assert.spy(vim.loop.write).was_called(5)
-        assert
-            .spy(vim.loop.write)
-            .was_called_with(match.is_ref(stdin), [[ $ErrorActionPreference = "Stop"; ]], match.is_function())
-        assert
-            .spy(vim.loop.write)
-            .was_called_with(match.is_ref(stdin), " $ProgressPreference = 'SilentlyContinue'; ", match.is_function())
-        assert.spy(vim.loop.write).was_called_with(
-            match.is_ref(stdin),
-            " [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; ",
-            match.is_function()
-        )
-        assert.spy(vim.loop.write).was_called_with(match.is_ref(stdin), "echo 'Is this bash?'", match.is_function())
-        assert.spy(vim.loop.write).was_called_with(match.is_ref(stdin), "\n", match.is_function())
-        assert.spy(vim.loop.shutdown).was_called(1)
-        assert.spy(vim.loop.shutdown).was_called_with(match.is_ref(stdin), match.is_function())
-    end)
-
     it("should provide default powershell options via command interface", function()
         stub(spawn, "pwsh", function() end)
         stub(vim.fn, "executable")
@@ -104,6 +59,7 @@ describe("powershell manager", function()
         assert.spy(spawn.pwsh).was_called(1)
         assert.spy(spawn.pwsh).was_called_with(match.tbl_containing {
             "-NoProfile",
+            "-NonInteractive",
             "-Command",
             [[ $ErrorActionPreference = "Stop";  $ProgressPreference = 'SilentlyContinue';  [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; echo 'Is this bash?']],
         })