chore(tests): use assert.same instead of abusing vim.inspect + assert.equal

9 files changed, 132 insertions, 204 deletions

diff --git a/tests/core/managers/cargo_spec.lua b/tests/core/managers/cargo_spec.lua
index 636a5f24..eb65aead 100644
--- a/tests/core/managers/cargo_spec.lua
+++ b/tests/core/managers/cargo_spec.lua
@@ -92,21 +92,18 @@ describe("cargo manager", function()
         "should provide receipt information",
         async_test(function()
             installer.run_installer(ctx, cargo.crate "main-package")
-            assert.equals(
-                vim.inspect {
-                    type = "cargo",
-                    package = "main-package",
-                },
-                vim.inspect(ctx.receipt.primary_source)
-            )
+            assert.same({
+                type = "cargo",
+                package = "main-package",
+            }, ctx.receipt.primary_source)
         end)
     )
 end)
 
 describe("cargo version check", function()
     it("parses cargo installed packages output", function()
-        assert.equal(
-            vim.inspect {
+        assert.same(
+            {
                 ["bat"] = "0.18.3",
                 ["exa"] = "0.10.1",
                 ["git-select-branch"] = "0.1.1",
@@ -115,7 +112,7 @@ describe("cargo version check", function()
                 ["stylua"] = "0.11.2",
                 ["zoxide"] = "0.5.0",
             },
-            vim.inspect(cargo.parse_installed_crates [[bat v0.18.3:
+            cargo.parse_installed_crates [[bat v0.18.3:
     bat
 exa v0.10.1:
     exa
@@ -129,7 +126,7 @@ stylua v0.11.2:
     stylua
 zoxide v0.5.0:
     zoxide
-]])
+]]
         )
     end)
 
diff --git a/tests/core/managers/composer_spec.lua b/tests/core/managers/composer_spec.lua
index e4365af0..cd3d7556 100644
--- a/tests/core/managers/composer_spec.lua
+++ b/tests/core/managers/composer_spec.lua
@@ -51,26 +51,20 @@ describe("composer manager", function()
                 ctx,
                 composer.packages { "main-package", "supporting-package", "supporting-package2" }
             )
-            assert.equals(
-                vim.inspect {
+            assert.same({
+                type = "composer",
+                package = "main-package",
+            }, ctx.receipt.primary_source)
+            assert.same({
+                {
                     type = "composer",
-                    package = "main-package",
+                    package = "supporting-package",
                 },
-                vim.inspect(ctx.receipt.primary_source)
-            )
-            assert.equals(
-                vim.inspect {
-                    {
-                        type = "composer",
-                        package = "supporting-package",
-                    },
-                    {
-                        type = "composer",
-                        package = "supporting-package2",
-                    },
+                {
+                    type = "composer",
+                    package = "supporting-package2",
                 },
-                vim.inspect(ctx.receipt.secondary_sources)
-            )
+            }, ctx.receipt.secondary_sources)
         end)
     )
 end)
@@ -155,14 +149,11 @@ describe("composer version check", function()
                 cwd = "/tmp/install/dir",
             }
             assert.is_true(result:is_success())
-            assert.equals(
-                vim.inspect {
-                    name = "vimeo/psalm",
-                    current_version = "4.0.0",
-                    latest_version = "4.22.0",
-                },
-                vim.inspect(result:get_or_nil())
-            )
+            assert.same({
+                name = "vimeo/psalm",
+                current_version = "4.0.0",
+                latest_version = "4.22.0",
+            }, result:get_or_nil())
 
             spawn.composer = nil
         end)
diff --git a/tests/core/managers/dotnet_spec.lua b/tests/core/managers/dotnet_spec.lua
index 8bc4bf06..d900bd17 100644
--- a/tests/core/managers/dotnet_spec.lua
+++ b/tests/core/managers/dotnet_spec.lua
@@ -36,13 +36,10 @@ describe("dotnet manager", function()
         async_test(function()
             ctx.requested_version = Optional.of "42.13.37"
             installer.run_installer(ctx, dotnet.package "main-package")
-            assert.equals(
-                vim.inspect {
-                    type = "dotnet",
-                    package = "main-package",
-                },
-                vim.inspect(ctx.receipt.primary_source)
-            )
+            assert.same({
+                type = "dotnet",
+                package = "main-package",
+            }, ctx.receipt.primary_source)
         end)
     )
 end)
diff --git a/tests/core/managers/gem_spec.lua b/tests/core/managers/gem_spec.lua
index 90d0c390..5e8d92bb 100644
--- a/tests/core/managers/gem_spec.lua
+++ b/tests/core/managers/gem_spec.lua
@@ -44,26 +44,20 @@ describe("gem manager", function()
         async_test(function()
             ctx.requested_version = Optional.of "42.13.37"
             installer.run_installer(ctx, gem.packages { "main-package", "supporting-package", "supporting-package2" })
-            assert.equals(
-                vim.inspect {
+            assert.same({
+                type = "gem",
+                package = "main-package",
+            }, ctx.receipt.primary_source)
+            assert.same({
+                {
                     type = "gem",
-                    package = "main-package",
+                    package = "supporting-package",
                 },
-                vim.inspect(ctx.receipt.primary_source)
-            )
-            assert.equals(
-                vim.inspect {
-                    {
-                        type = "gem",
-                        package = "supporting-package",
-                    },
-                    {
-                        type = "gem",
-                        package = "supporting-package2",
-                    },
+                {
+                    type = "gem",
+                    package = "supporting-package2",
                 },
-                vim.inspect(ctx.receipt.secondary_sources)
-            )
+            }, ctx.receipt.secondary_sources)
         end)
     )
 end)
@@ -147,14 +141,11 @@ solargraph (0.44.0 < 0.44.3)
                 },
             })
             assert.is_true(result:is_success())
-            assert.equals(
-                vim.inspect {
-                    name = "solargraph",
-                    current_version = "0.44.0",
-                    latest_version = "0.44.3",
-                },
-                vim.inspect(result:get_or_nil())
-            )
+            assert.same({
+                name = "solargraph",
+                current_version = "0.44.0",
+                latest_version = "0.44.3",
+            }, result:get_or_nil())
 
             spawn.gem = nil
         end)
@@ -187,22 +178,16 @@ solargraph (0.44.0 < 0.44.3)
 
     it("parses outdated gem output", function()
         local normalize = gem.parse_outdated_gem
-        assert.equal(
-            vim.inspect {
-                name = "solargraph",
-                current_version = "0.42.2",
-                latest_version = "0.44.2",
-            },
-            vim.inspect(normalize [[solargraph (0.42.2 < 0.44.2)]])
-        )
-        assert.equal(
-            vim.inspect {
-                name = "sorbet-runtime",
-                current_version = "0.5.9307",
-                latest_version = "0.5.9468",
-            },
-            vim.inspect(normalize [[sorbet-runtime (0.5.9307 < 0.5.9468)]])
-        )
+        assert.same({
+            name = "solargraph",
+            current_version = "0.42.2",
+            latest_version = "0.44.2",
+        }, normalize [[solargraph (0.42.2 < 0.44.2)]])
+        assert.same({
+            name = "sorbet-runtime",
+            current_version = "0.5.9307",
+            latest_version = "0.5.9468",
+        }, normalize [[sorbet-runtime (0.5.9307 < 0.5.9468)]])
     end)
 
     it("returns nil when unable to parse outdated gem", function()
@@ -211,19 +196,19 @@ solargraph (0.44.0 < 0.44.3)
     end)
 
     it("should parse gem list output", function()
-        assert.equals(
-            vim.inspect {
+        assert.same(
+            {
                 ["solargraph"] = "0.44.3",
                 ["unicode-display_width"] = "2.1.0",
             },
-            vim.inspect(gem.parse_gem_list_output [[
+            gem.parse_gem_list_output [[
 
 *** LOCAL GEMS ***
 
 nokogiri (1.13.3 arm64-darwin)
 solargraph (0.44.3)
 unicode-display_width (2.1.0)
-]])
+]]
         )
     end)
 end)
diff --git a/tests/core/managers/git_spec.lua b/tests/core/managers/git_spec.lua
index 25e58f6e..1b73c5f6 100644
--- a/tests/core/managers/git_spec.lua
+++ b/tests/core/managers/git_spec.lua
@@ -82,13 +82,10 @@ describe("git manager", function()
             installer.run_installer(ctx, function()
                 git.clone({ "https://github.com/williamboman/nvim-lsp-installer.git" }).with_receipt()
             end)
-            assert.equals(
-                vim.inspect {
-                    type = "git",
-                    remote = "https://github.com/williamboman/nvim-lsp-installer.git",
-                },
-                vim.inspect(ctx.receipt.primary_source)
-            )
+            assert.same({
+                type = "git",
+                remote = "https://github.com/williamboman/nvim-lsp-installer.git",
+            }, ctx.receipt.primary_source)
             assert.is_true(#ctx.receipt.secondary_sources == 0)
         end)
     )
@@ -149,14 +146,11 @@ describe("git version check", function()
                 cwd = "/tmp/install/dir",
             }
             assert.is_true(result:is_success())
-            assert.equals(
-                vim.inspect {
-                    name = "https://github.com/williamboman/nvim-lsp-installer.git",
-                    current_version = "19c668cd10695b243b09452f0dfd53570c1a2e7d",
-                    latest_version = "728307a74cd5f2dec7ca2ca164785c25673d6328",
-                },
-                vim.inspect(result:get_or_nil())
-            )
+            assert.same({
+                name = "https://github.com/williamboman/nvim-lsp-installer.git",
+                current_version = "19c668cd10695b243b09452f0dfd53570c1a2e7d",
+                latest_version = "728307a74cd5f2dec7ca2ca164785c25673d6328",
+            }, result:get_or_nil())
 
             spawn.git = nil
         end)
diff --git a/tests/core/managers/go_spec.lua b/tests/core/managers/go_spec.lua
index c7218335..c2a97ff5 100644
--- a/tests/core/managers/go_spec.lua
+++ b/tests/core/managers/go_spec.lua
@@ -50,26 +50,20 @@ describe("go manager", function()
         async_test(function()
             ctx.requested_version = Optional.of "42.13.37"
             installer.run_installer(ctx, go.packages { "main-package", "supporting-package", "supporting-package2" })
-            assert.equals(
-                vim.inspect {
+            assert.same({
+                type = "go",
+                package = "main-package",
+            }, ctx.receipt.primary_source)
+            assert.same({
+                {
                     type = "go",
-                    package = "main-package",
+                    package = "supporting-package",
                 },
-                vim.inspect(ctx.receipt.primary_source)
-            )
-            assert.equals(
-                vim.inspect {
-                    {
-                        type = "go",
-                        package = "supporting-package",
-                    },
-                    {
-                        type = "go",
-                        package = "supporting-package2",
-                    },
+                {
+                    type = "go",
+                    package = "supporting-package2",
                 },
-                vim.inspect(ctx.receipt.secondary_sources)
-            )
+            }, ctx.receipt.secondary_sources)
         end)
     )
 end)
@@ -87,15 +81,12 @@ gopls: go1.18
 
     it("should parse go version output", function()
         local parsed = go.parse_mod_version_output(go_version_output)
-        assert.equals(
-            vim.inspect {
-                path = { ["golang.org/x/tools/gopls"] = "" },
-                mod = { ["golang.org/x/tools/gopls"] = "v0.8.1" },
-                dep = { ["github.com/google/go-cmp"] = "v0.5.7", ["mvdan.cc/xurls/v2"] = "v2.4.0" },
-                build = { ["-compiler=gc"] = "", ["GOOS=darwin"] = "" },
-            },
-            vim.inspect(parsed)
-        )
+        assert.same({
+            path = { ["golang.org/x/tools/gopls"] = "" },
+            mod = { ["golang.org/x/tools/gopls"] = "v0.8.1" },
+            dep = { ["github.com/google/go-cmp"] = "v0.5.7", ["mvdan.cc/xurls/v2"] = "v2.4.0" },
+            build = { ["-compiler=gc"] = "", ["GOOS=darwin"] = "" },
+        }, parsed)
     end)
 
     it(
@@ -172,14 +163,11 @@ gopls: go1.18
             )
 
             assert.is_true(result:is_success())
-            assert.equals(
-                vim.inspect {
-                    name = "golang.org/x/tools/gopls",
-                    current_version = "v0.8.1",
-                    latest_version = "v2.0.0",
-                },
-                vim.inspect(result:get_or_nil())
-            )
+            assert.same({
+                name = "golang.org/x/tools/gopls",
+                current_version = "v0.8.1",
+                latest_version = "v2.0.0",
+            }, result:get_or_nil())
 
             spawn.go = nil
         end)
diff --git a/tests/core/managers/npm_spec.lua b/tests/core/managers/npm_spec.lua
index 2d804572..ab2cb1f4 100644
--- a/tests/core/managers/npm_spec.lua
+++ b/tests/core/managers/npm_spec.lua
@@ -66,26 +66,20 @@ describe("npm manager", function()
         async_test(function()
             ctx.requested_version = Optional.of "42.13.37"
             installer.run_installer(ctx, npm.packages { "main-package", "supporting-package", "supporting-package2" })
-            assert.equals(
-                vim.inspect {
+            assert.same({
+                type = "npm",
+                package = "main-package",
+            }, ctx.receipt.primary_source)
+            assert.same({
+                {
                     type = "npm",
-                    package = "main-package",
+                    package = "supporting-package",
                 },
-                vim.inspect(ctx.receipt.primary_source)
-            )
-            assert.equals(
-                vim.inspect {
-                    {
-                        type = "npm",
-                        package = "supporting-package",
-                    },
-                    {
-                        type = "npm",
-                        package = "supporting-package2",
-                    },
+                {
+                    type = "npm",
+                    package = "supporting-package2",
                 },
-                vim.inspect(ctx.receipt.secondary_sources)
-            )
+            }, ctx.receipt.secondary_sources)
         end)
     )
 end)
@@ -168,14 +162,11 @@ describe("npm version check", function()
                 cwd = "/tmp/install/dir",
             }
             assert.is_true(result:is_success())
-            assert.equals(
-                vim.inspect {
-                    name = "bash-language-server",
-                    current_version = "1.17.0",
-                    latest_version = "2.0.0",
-                },
-                vim.inspect(result:get_or_nil())
-            )
+            assert.same({
+                name = "bash-language-server",
+                current_version = "1.17.0",
+                latest_version = "2.0.0",
+            }, result:get_or_nil())
 
             spawn.npm = nil
         end)
diff --git a/tests/core/managers/opam_spec.lua b/tests/core/managers/opam_spec.lua
index 39e892ca..8f1ebe5d 100644
--- a/tests/core/managers/opam_spec.lua
+++ b/tests/core/managers/opam_spec.lua
@@ -40,26 +40,20 @@ describe("opam manager", function()
         async_test(function()
             ctx.requested_version = Optional.of "42.13.37"
             installer.run_installer(ctx, opam.packages { "main-package", "supporting-package", "supporting-package2" })
-            assert.equals(
-                vim.inspect {
+            assert.same({
+                type = "opam",
+                package = "main-package",
+            }, ctx.receipt.primary_source)
+            assert.same({
+                {
                     type = "opam",
-                    package = "main-package",
+                    package = "supporting-package",
                 },
-                vim.inspect(ctx.receipt.primary_source)
-            )
-            assert.equals(
-                vim.inspect {
-                    {
-                        type = "opam",
-                        package = "supporting-package",
-                    },
-                    {
-                        type = "opam",
-                        package = "supporting-package2",
-                    },
+                {
+                    type = "opam",
+                    package = "supporting-package2",
                 },
-                vim.inspect(ctx.receipt.secondary_sources)
-            )
+            }, ctx.receipt.secondary_sources)
         end)
     )
 end)
diff --git a/tests/core/managers/pip3_spec.lua b/tests/core/managers/pip3_spec.lua
index 344c177c..adbda4ec 100644
--- a/tests/core/managers/pip3_spec.lua
+++ b/tests/core/managers/pip3_spec.lua
@@ -122,26 +122,20 @@ describe("pip3 manager", function()
         async_test(function()
             ctx.requested_version = Optional.of "42.13.37"
             installer.run_installer(ctx, pip3.packages { "main-package", "supporting-package", "supporting-package2" })
-            assert.equals(
-                vim.inspect {
+            assert.same({
+                type = "pip3",
+                package = "main-package",
+            }, ctx.receipt.primary_source)
+            assert.same({
+                {
                     type = "pip3",
-                    package = "main-package",
+                    package = "supporting-package",
                 },
-                vim.inspect(ctx.receipt.primary_source)
-            )
-            assert.equals(
-                vim.inspect {
-                    {
-                        type = "pip3",
-                        package = "supporting-package",
-                    },
-                    {
-                        type = "pip3",
-                        package = "supporting-package2",
-                    },
+                {
+                    type = "pip3",
+                    package = "supporting-package2",
                 },
-                vim.inspect(ctx.receipt.secondary_sources)
-            )
+            }, ctx.receipt.secondary_sources)
         end)
     )
 end)
@@ -216,14 +210,11 @@ describe("pip3 version check", function()
                 env = match.table(),
             })
             assert.is_true(result:is_success())
-            assert.equals(
-                vim.inspect {
-                    name = "python-lsp-server",
-                    current_version = "1.3.0",
-                    latest_version = "1.4.0",
-                },
-                vim.inspect(result:get_or_nil())
-            )
+            assert.same({
+                name = "python-lsp-server",
+                current_version = "1.3.0",
+                latest_version = "1.4.0",
+            }, result:get_or_nil())
 
             spawn.python = nil
         end)