leverage PATH for locating local executables (#283)

1. This is a breaking change for the following servers, which will have to be
reinstalled:

 - ltex
 - clangd

2. This is a breaking change for users who reach into the default options (for
   example via server:get_default_options()) to access the `cmd` property.
   nvim-lsp-installer no longer provides the `cmd` (except in a few
   instances), but instead provides an amended PATH which allows neovim's LSP
   client to locate the locally installed executable.

   To access the `cmd`, simply access it via lspconfig instead, for example
   like so:

    local default_config = require("lspconfig.server_configurations.rust_analyzer").default_config
    print("I can now access the cmd governed by lspconfig:", default_config.cmd)

3. This is a breaking change for 3rd party use cases that makes use of the
   `executable()` APIs (e.g., `npm.executable(root_dir, "tsserver")`). The
   recommended usage is to instead to use the canonical name of the command
   ("tsserver"), while providing an amended PATH, for example:

    local npm = require("nvim-lsp-installer.installers.npm")
    local server = server.Server:new {
        ...,
        root_dir = root_dir,
        installer = npm.packages { "tsserver" },
        default_options = {
            cmd = { "tsserver" },
            cmd_env = npm.env(root_dir),
        }
    }

1 files changed, 1 insertions, 4 deletions

diff --git a/lua/nvim-lsp-installer/process.lua b/lua/nvim-lsp-installer/process.lua
index 9316fd38..87a4b950 100644
--- a/lua/nvim-lsp-installer/process.lua
+++ b/lua/nvim-lsp-installer/process.lua
@@ -39,10 +39,7 @@ local initial_environ = vim.fn.environ()
 ---@param new_paths string[] @A list of paths to prepend the existing PATH with.
 function M.extend_path(new_paths)
     local new_path_str = table.concat(new_paths, platform.path_sep)
-    if initial_environ["PATH"] then
-        return new_path_str .. platform.path_sep .. initial_environ["PATH"]
-    end
-    return new_path_str
+    return ("%s%s%s"):format(new_path_str, platform.path_sep, initial_environ.PATH or "")
 end
 
 ---Merges the provided env param with the user's full environent. Provided env has precedence.