diff options
| author | William Boman <william@redwill.se> | 2023-10-11 18:49:29 +0200 |
|---|---|---|
| committer | William Boman <william@redwill.se> | 2025-02-19 09:23:19 +0100 |
| commit | 6e2bc51ff72948ae043f3518a92784202260fa1c (patch) | |
| tree | b9593333b04620aa6b09c37e4deed5c88d435c77 | |
| parent | chore(compilers): remove default environment from github build compiler (diff) | |
| download | mason-6e2bc51ff72948ae043f3518a92784202260fa1c.tar mason-6e2bc51ff72948ae043f3518a92784202260fa1c.tar.gz mason-6e2bc51ff72948ae043f3518a92784202260fa1c.tar.bz2 mason-6e2bc51ff72948ae043f3518a92784202260fa1c.tar.lz mason-6e2bc51ff72948ae043f3518a92784202260fa1c.tar.xz mason-6e2bc51ff72948ae043f3518a92784202260fa1c.tar.zst mason-6e2bc51ff72948ae043f3518a92784202260fa1c.zip | |
chore: remove todo comment
Using sync is actually preferable here (and likely in many other places) to avoid async context & continuation overhead.
| -rw-r--r-- | lua/mason-core/installer/compiler/link.lua | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lua/mason-core/installer/compiler/link.lua b/lua/mason-core/installer/compiler/link.lua index 5d136322..9719eaa9 100644 --- a/lua/mason-core/installer/compiler/link.lua +++ b/lua/mason-core/installer/compiler/link.lua @@ -213,7 +213,6 @@ local function expand_file_spec(ctx, purl, source, file_spec_table) ---@type string[] local files = _.filter_map(function(abs_path) - -- fs.sync because async causes stack overflow on many files (TODO fix that) if not fs.sync.file_exists(abs_path) then -- only link actual files (e.g. exclude directory entries from glob) return Optional.empty() |