diff options
| author | William Boman <william@redwill.se> | 2025-02-16 18:40:10 +0100 |
|---|---|---|
| committer | William Boman <william@redwill.se> | 2025-02-19 12:15:49 +0100 |
| commit | 59cae87d5c74c25b761c220c7dbed8f5073ba0cb (patch) | |
| tree | bd31fe0989e5c9d9e4c8be7b632277a5fdbc0fce | |
| parent | refactor: turn StdioSink into a proper class (diff) | |
| download | mason-59cae87d5c74c25b761c220c7dbed8f5073ba0cb.tar mason-59cae87d5c74c25b761c220c7dbed8f5073ba0cb.tar.gz mason-59cae87d5c74c25b761c220c7dbed8f5073ba0cb.tar.bz2 mason-59cae87d5c74c25b761c220c7dbed8f5073ba0cb.tar.lz mason-59cae87d5c74c25b761c220c7dbed8f5073ba0cb.tar.xz mason-59cae87d5c74c25b761c220c7dbed8f5073ba0cb.tar.zst mason-59cae87d5c74c25b761c220c7dbed8f5073ba0cb.zip | |
chore: remove unnecessary vim.schedule and nvim_err_writeln
| -rw-r--r-- | lua/mason-core/EventEmitter.lua | 5 | ||||
| -rw-r--r-- | tests/mason-core/EventEmitter_spec.lua | 11 |
2 files changed, 8 insertions, 8 deletions
diff --git a/lua/mason-core/EventEmitter.lua b/lua/mason-core/EventEmitter.lua index 8a936cb9..43c32bad 100644 --- a/lua/mason-core/EventEmitter.lua +++ b/lua/mason-core/EventEmitter.lua @@ -27,10 +27,7 @@ end local function call_handler(event, handler, ...) local ok, err = pcall(handler, ...) if not ok then - vim.schedule(function() - log.fmt_warn("EventEmitter handler failed for event %s with error %s", event, err) - vim.api.nvim_err_writeln(err) - end) + log.fmt_warn("EventEmitter handler failed for event %s with error %s", event, err) end end diff --git a/tests/mason-core/EventEmitter_spec.lua b/tests/mason-core/EventEmitter_spec.lua index 76a9964b..c5219356 100644 --- a/tests/mason-core/EventEmitter_spec.lua +++ b/tests/mason-core/EventEmitter_spec.lua @@ -1,3 +1,4 @@ +local log = require "mason-core.log" local match = require "luassert.match" local spy = require "luassert.spy" @@ -42,13 +43,15 @@ describe("EventEmitter", function() assert.spy(my_event_handler).was_called(0) end) - it("should print errors in handlers", function() - spy.on(vim.api, "nvim_err_writeln") + it("should log errors in handlers", function() + spy.on(log, "fmt_warn") local emitter = EventEmitter.init(setmetatable({}, { __index = EventEmitter })) emitter:on("event", mockx.throws "My error.") emitter:emit "event" a.run_blocking(a.wait, vim.schedule) - assert.spy(vim.api.nvim_err_writeln).was_called(1) - assert.spy(vim.api.nvim_err_writeln).was_called_with "My error." + assert.spy(log.fmt_warn).was_called(1) + assert + .spy(log.fmt_warn) + .was_called_with("EventEmitter handler failed for event %s with error %s", "event", "My error.") end) end) |
