diff options
| author | Chris Grieser <73286100+chrisgrieser@users.noreply.github.com> | 2025-05-21 15:37:54 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-05-21 06:37:54 -0700 |
| commit | 71be9bbe9ed2d51d9114f92a5dcb7b5f1dcb0830 (patch) | |
| tree | 872b5f1ba480f04836d038c3943fcd3335d94722 | |
| parent | docs: update configs.md (diff) | |
| download | nvim-lspconfig-71be9bbe9ed2d51d9114f92a5dcb7b5f1dcb0830.tar nvim-lspconfig-71be9bbe9ed2d51d9114f92a5dcb7b5f1dcb0830.tar.gz nvim-lspconfig-71be9bbe9ed2d51d9114f92a5dcb7b5f1dcb0830.tar.bz2 nvim-lspconfig-71be9bbe9ed2d51d9114f92a5dcb7b5f1dcb0830.tar.lz nvim-lspconfig-71be9bbe9ed2d51d9114f92a5dcb7b5f1dcb0830.tar.xz nvim-lspconfig-71be9bbe9ed2d51d9114f92a5dcb7b5f1dcb0830.tar.zst nvim-lspconfig-71be9bbe9ed2d51d9114f92a5dcb7b5f1dcb0830.zip | |
fix(gh_actions_ls): use `root_dir`, add `init_options` #3857
1. Replace `root_markers` and `workspace_required = true` with a `root_dir` function that checks the file is located in the correct location. This prevents some edge cases where the LSP would still attach to non-workflow files. This also makes unnecessary to use a `yaml.github` filetype, [as the readme of the lsp describes](https://github.com/lttb/gh-actions-language-server?tab=readme-ov-file#add-yamlgithub-filetype-detection).
2. add an empty `init_options` table, since such a table is apparently needed by the LSP: https://github.com/neovim/nvim-lspconfig/pull/3713#issuecomment-2857394868
| -rw-r--r-- | lsp/gh_actions_ls.lua | 21 |
1 files changed, 14 insertions, 7 deletions
diff --git a/lsp/gh_actions_ls.lua b/lsp/gh_actions_ls.lua index 9fe42193..62e3d9e7 100644 --- a/lsp/gh_actions_ls.lua +++ b/lsp/gh_actions_ls.lua @@ -15,14 +15,21 @@ --- ``` return { cmd = { 'gh-actions-language-server', '--stdio' }, - -- the `root_markers` with `workspace_required` prevent attaching to every yaml file filetypes = { 'yaml' }, - root_markers = { - '.github/workflows', - '.forgejo/workflows', - '.gitea/workflows', - }, - workspace_required = true, + + -- `root_dir` ensures that the LSP does not attach to all yaml files + root_dir = function(bufnr, on_dir) + local parent = vim.fs.dirname(vim.api.nvim_buf_get_name(bufnr)) + if + vim.endswith(parent, '/.github/workflows') + or vim.endswith(parent, '/.forgejo/workflows') + or vim.endswith(parent, '/.gitea/workflows') + then + on_dir(parent) + end + end, + + init_options = {}, -- needs to be present https://github.com/neovim/nvim-lspconfig/pull/3713#issuecomment-2857394868 capabilities = { workspace = { didChangeWorkspaceFolders = { |