From 6a5339fdd517fc59ce576cf3bbd0cd73c0edfa14 Mon Sep 17 00:00:00 2001 From: Mikael Magnusson Date: Tue, 6 Jan 2015 00:40:23 +0100 Subject: 34107: getsubsargs: free ptr1 before returning Found by Coverity (Issue 439073). --- ChangeLog | 2 ++ Src/hist.c | 1 + 2 files changed, 3 insertions(+) diff --git a/ChangeLog b/ChangeLog index f54188af9..1b3076632 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2015-01-06 Mikael Magnusson + * 34107: Src/hist.c: getsubsargs: free ptr1 before returning + * 34134: Src/exec.c: anon funcs: don't leak shf and related data * 34112: Src/builtin.c: typeset: fix leak of oldval diff --git a/Src/hist.c b/Src/hist.c index d8192c1c5..e65d78bfd 100644 --- a/Src/hist.c +++ b/Src/hist.c @@ -367,6 +367,7 @@ getsubsargs(char *subline, int *gbalp, int *cflagp) zsfree(hsubl); hsubl = ptr1; } else if (!hsubl) { /* fail silently on this */ + zsfree(ptr1); zsfree(ptr2); return 0; } -- cgit v1.3.1