From 047ec18da56ad8f331e5c6bc7417dc5a9a6e71cc Mon Sep 17 00:00:00 2001
From: William Boman <william@redwill.se>
Date: Wed, 11 Oct 2023 16:31:50 +0200
Subject: refactor!: refactor installer internals and add new Package class
 methods (#1523)

This contains the following changes:
1) `Package:install()` now accepts a second, optional, callback argument which is called when installation finishes
   (successfully or not).
2) Adds a `Package:is_installing()` method.

This contains the following breaking changes:
1) `Package:install()` will now error when called while an installation is already ongoing. Use the new
   `Package:is_installing()` method to check whether an installation is already running.

This also refactors large portions of the tests by removing test globals, removing async_test, and adding the
`mason-test` Lua module instead. Test helpers via globals are problematic to work with due to not being detected through
tools like the Lua language server without additional configuration. This has been replaced with a Lua module
`mason-test`. `async_test` has also been removed in favour of explicitly making use of the `mason-core.async` API. These
changes stands for a significant portion of the diff.
---
 tests/helpers/lua/test_helpers.lua | 70 --------------------------------------
 1 file changed, 70 deletions(-)
 delete mode 100644 tests/helpers/lua/test_helpers.lua

(limited to 'tests/helpers/lua/test_helpers.lua')

diff --git a/tests/helpers/lua/test_helpers.lua b/tests/helpers/lua/test_helpers.lua
deleted file mode 100644
index c7d6f983..00000000
--- a/tests/helpers/lua/test_helpers.lua
+++ /dev/null
@@ -1,70 +0,0 @@
----@diagnostic disable: lowercase-global
-local spy = require "luassert.spy"
-local util = require "luassert.util"
-
-local InstallContext = require "mason-core.installer.context"
-local InstallHandle = require "mason-core.installer.handle"
-local Result = require "mason-core.result"
-local a = require "mason-core.async"
-local path = require "mason-core.path"
-local registry = require "mason-registry"
-
--- selene: allow(unused_variable)
-function async_test(suspend_fn)
-    return function()
-        local ok, err = pcall(a.run_blocking, suspend_fn)
-        if not ok then
-            error(err, util.errorlevel())
-        end
-    end
-end
-
--- selene: allow(unscoped_variables, incorrect_standard_library_use)
-mockx = {
-    just_runs = function() end,
-    returns = function(val)
-        return function()
-            return val
-        end
-    end,
-    throws = function(exception)
-        return function()
-            error(exception, 2)
-        end
-    end,
-}
-
----@param opts? PackageInstallOpts
-function create_dummy_context(opts)
-    local ctx = InstallContextGenerator(InstallHandleGenerator "registry", opts)
-    ctx.cwd:set(path.package_build_prefix "registry")
-    ctx.spawn = setmetatable({}, {
-        __index = function(s, cmd)
-            s[cmd] = spy.new(function()
-                return Result.success { stdout = nil, stderr = nil }
-            end)
-            return s[cmd]
-        end,
-    })
-    return ctx
-end
-
--- selene: allow(unused_variable)
----@param package_name string
-function InstallHandleGenerator(package_name)
-    return InstallHandle.new(registry.get_package(package_name))
-end
-
--- selene: allow(unused_variable)
----@param handle InstallHandle
----@param opts PackageInstallOpts?
-function InstallContextGenerator(handle, opts)
-    local context = InstallContext.new(handle, opts or {})
-    context.spawn = setmetatable({ strict_mode = true }, {
-        __index = function(self, cmd)
-            self[cmd] = spy.new(mockx.just_runs())
-            return self[cmd]
-        end,
-    })
-    return context
-end
-- 
cgit v1.2.3-70-g09d2