From 095ab4eb6a02d5fd3ea4b782a0e868e2c65e4427 Mon Sep 17 00:00:00 2001
From: William Boman <william@redwill.se>
Date: Sun, 2 Jan 2022 17:54:56 +0100
Subject: leverage PATH for locating local executables (#283)

1. This is a breaking change for the following servers, which will have to be
reinstalled:

 - ltex
 - clangd

2. This is a breaking change for users who reach into the default options (for
   example via server:get_default_options()) to access the `cmd` property.
   nvim-lsp-installer no longer provides the `cmd` (except in a few
   instances), but instead provides an amended PATH which allows neovim's LSP
   client to locate the locally installed executable.

   To access the `cmd`, simply access it via lspconfig instead, for example
   like so:

    local default_config = require("lspconfig.server_configurations.rust_analyzer").default_config
    print("I can now access the cmd governed by lspconfig:", default_config.cmd)

3. This is a breaking change for 3rd party use cases that makes use of the
   `executable()` APIs (e.g., `npm.executable(root_dir, "tsserver")`). The
   recommended usage is to instead to use the canonical name of the command
   ("tsserver"), while providing an amended PATH, for example:

    local npm = require("nvim-lsp-installer.installers.npm")
    local server = server.Server:new {
        ...,
        root_dir = root_dir,
        installer = npm.packages { "tsserver" },
        default_options = {
            cmd = { "tsserver" },
            cmd_env = npm.env(root_dir),
        }
    }
---
 lua/nvim-lsp-installer/servers/angularls/init.lua | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'lua/nvim-lsp-installer/servers/angularls/init.lua')

diff --git a/lua/nvim-lsp-installer/servers/angularls/init.lua b/lua/nvim-lsp-installer/servers/angularls/init.lua
index 8492749c..7e2efa27 100644
--- a/lua/nvim-lsp-installer/servers/angularls/init.lua
+++ b/lua/nvim-lsp-installer/servers/angularls/init.lua
@@ -14,7 +14,7 @@ end
 return function(name, root_dir)
     local function get_cmd(workspace_dir)
         return {
-            npm.executable(root_dir, "ngserver"),
+            "ngserver",
             "--stdio",
             "--tsProbeLocations",
             table.concat(append_node_modules { root_dir, workspace_dir }, ","),
@@ -37,6 +37,7 @@ return function(name, root_dir)
         installer = npm.packages { "@angular/language-server", "typescript" },
         default_options = {
             cmd = get_cmd(path.cwd()),
+            cmd_env = npm.env(root_dir),
             on_new_config = function(new_config, new_root_dir)
                 new_config.cmd = get_cmd(new_root_dir)
             end,
-- 
cgit v1.2.3-70-g09d2