From 095ab4eb6a02d5fd3ea4b782a0e868e2c65e4427 Mon Sep 17 00:00:00 2001 From: William Boman Date: Sun, 2 Jan 2022 17:54:56 +0100 Subject: leverage PATH for locating local executables (#283) 1. This is a breaking change for the following servers, which will have to be reinstalled: - ltex - clangd 2. This is a breaking change for users who reach into the default options (for example via server:get_default_options()) to access the `cmd` property. nvim-lsp-installer no longer provides the `cmd` (except in a few instances), but instead provides an amended PATH which allows neovim's LSP client to locate the locally installed executable. To access the `cmd`, simply access it via lspconfig instead, for example like so: local default_config = require("lspconfig.server_configurations.rust_analyzer").default_config print("I can now access the cmd governed by lspconfig:", default_config.cmd) 3. This is a breaking change for 3rd party use cases that makes use of the `executable()` APIs (e.g., `npm.executable(root_dir, "tsserver")`). The recommended usage is to instead to use the canonical name of the command ("tsserver"), while providing an amended PATH, for example: local npm = require("nvim-lsp-installer.installers.npm") local server = server.Server:new { ..., root_dir = root_dir, installer = npm.packages { "tsserver" }, default_options = { cmd = { "tsserver" }, cmd_env = npm.env(root_dir), } } --- lua/nvim-lsp-installer/server.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lua/nvim-lsp-installer/server.lua') diff --git a/lua/nvim-lsp-installer/server.lua b/lua/nvim-lsp-installer/server.lua index 1a23bbbd..153b0605 100644 --- a/lua/nvim-lsp-installer/server.lua +++ b/lua/nvim-lsp-installer/server.lua @@ -72,7 +72,7 @@ end ---Attaches this server to all current open buffers with a 'filetype' that matches the server's configured filetypes. function M.Server:attach_buffers() - log.debug("Attaching server to buffers", self.name) + log.trace("Attaching server to buffers", self.name) local lsp_server = require("lspconfig")[self.name] for _, bufnr in ipairs(vim.api.nvim_list_bufs()) do if lsp_server.filetypes then @@ -83,7 +83,7 @@ function M.Server:attach_buffers() lsp_server.manager.try_add(bufnr) end end - log.debug("Successfully attached server to buffers", self.name) + log.trace("Successfully attached server to buffers", self.name) end ---Registers a handler (callback) to be executed when the server is ready to be setup. -- cgit v1.2.3-70-g09d2