zsh/Src/Zle/zle_thingy.c, branch master[no description]http://git.sudomsg.com/mirror/zsh/atom/Src/Zle/zle_thingy.c?h=master2026-07-19T20:34:52Z54809: ZLE specials are always in realparamtab and can't be namerefs2026-07-19T20:34:52ZPhilippe Altherrphilippe.altherr@gmail.com2026-07-19T20:34:52Zurn:sha1:27b7b59af8ba0e6993416436b09e7fb859311fb954710: handle multibyte arguments in error messages2026-06-13T23:56:15ZMikael Magnussonmikachu@gmail.com2026-06-06T23:48:20Zurn:sha1:e5f58a80ba5124735d6434845ea382a5db1f1875
A lot of places check option strings char by char, then send that char
to zwarn/zerr, instead of reading out the full multibyte character.
Doing so is quite easy with unmeta_one in most cases, so just go ahead
and do that. The print functions in fact expect a wchar_t for %c anyway.
Also renames "unknown option" to "bad option" because that's what every
other place calls it (also one place was missing the colon, added that).
To reproduce the math errors, since it's slightly less obvious (you need
a multibyte character that is also an invalid parameter name, otherwise
it actually works fine)
% zsh -c '(( ¯ ))'
zsh:1: bad math expression: illegal character: ^
% zsh -c 'zmodload zsh/mathfunc; (( sin(1¯) ))'
zsh:1: bad math expression: illegal character: ^
% zsh -c 'の=5; echo $(( の ))' # unchanged because it is working
5
Also adds some tests because B12 was looking very empty, not sure if
this is the correct way to handle the intersection of possibly not
compiled module with possibly not available UTF-8 locale, but X02 and
some others do a similar thing with ZSH_TEST_LANG, though in those cases
that's handled specially by comptest, not the test itself.
54569: zle: various issues2026-05-16T16:28:32ZMikael Magnussonmikachu@gmail.com2026-05-13T18:59:29Zurn:sha1:724548b4e9fa054d2fca7383cbe5627f1f65cadb
historysearchforward advanced zlecs instead of histpos
(historysearchbackward already correctly uses CCRIGHTPOS(histpos)
ST is actually 0x9c per ctlseqs.txt
ESC \
String Terminator (ST is 0x9c).
fix plenty of indexing confusion with prompt_markers(), it was never
returning pre because markers did not include it. constants were
compared against the wrong variable, or using the wrong hardcoded index
(and those indices also changed now that pre is in markers).
in bracketedstring, the imeta(next) branch writes two bytes to pbuf,
make sure they both fit.
only reallocate once in sizeline, and correct the comment for
stringaszleline, though I don't think anyone will do that.
putreplaceselection used a stale buffer in the following scenario:
% blah
set region to bl with cursor on a, hit ctrl-k, then invoke
put-replace-selection via alt-x or bind it in advance.
==10588== Invalid read of size 2
==10588== by 0x6588FAA: pastebuf (zle_misc.c:597)
==10588== by 0x65895A6: putreplaceselection (zle_misc.c:720)
==10588== Address 0x6219550 is 0 bytes inside a block of size 16 free'd
==10588== at 0x483C17B: free (vgpreload_memcheck-amd64-linux.so)
==10588== by 0x65A347A: cuttext (zle_utils.c:1023)
==10588== Block was alloc'd at
==10588== at 0x483E82F: realloc (vgpreload_memcheck-amd64-linux.so)
==10588== by 0x65A34E8: cuttext (zle_utils.c:1028)
also set clear so the stringaszleline allocation is freed in the same
function, and fix the same leak in viputbefore and viputafter.
fix out of bounds access in vimatchbracket
==11986== Invalid read of size 4
==11986== at 0x658D14C: vimatchbracket (zle_move.c:645)
fix out of bounds access in backwardmetafiedchar, this one won't cause a
valgrind warning because the memory is owned by us.
fix two separate leaks (impressive) when assigning to $registers special zle parameter
==16615== 2,799,972 bytes in 99,999 blocks are definitely lost in loss record 631 of 631
==16615== at 0x48397B5: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==16615== by 0x473836: zalloc (mem.c:966)
==16615== by 0x65A1EEC: stringaszleline (zle_utils.c:440)
==16615== by 0x658EF17: set_register (zle_params.c:775)
==16615== 599,988 bytes in 99,998 blocks are definitely lost in loss record 630 of 631
==16615== at 0x48397B5: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==16615== by 0x473836: zalloc (mem.c:966)
==16615== by 0x4AA101: ztrdup (string.c:68)
==16615== by 0x435536: addvars (exec.c:2604)
don't crash on 'bindkey x foo; zle -l foo'
==21910== Process terminating with default action of signal 11 (SIGSEGV)
==21910== Access not within mapped region at address 0x0
==21910== at 0x6597303: bin_zle_list (zle_thingy.c:406)
==21910== by 0x6597229: bin_zle (zle_thingy.c:388)
restore keymap and zmod when erroring out of bin_zle_call
inststrlen used the wrong len to advance zlecs which would cause it to
advance way past the end of zleline. fortunately this function is never
called with zlemetaline == NULL.
fix expand-cmd-path to not just move the cursor an arbitrary
amount forward, and convert the indices from zlemetaline to zleline.
bangq in magicspace could be used after zleline was realloc()d,
calculate the offset before calling selfinsert()
the memo field wasn't always freed for region highlights
vi-indent was skipping the last line for 4+ line ranges
vi-unindent buffer overrun
==3900== Conditional jump or move depends on uninitialised value(s)
==3900== at 0x65A3CE6: findeol (zle_utils.c:1180)
==3900== by 0x65A6E01: viunindent (zle_vi.c:880)
break the loop on eof in vi-caps-lock-panic, though we do exit anyway
when the terminal closes
off by one in condition in vi-backward-word-end, this only prevented us
moving to the start of the buffer if we were on the second character
exactly.
seq in cursor_form() was one byte too small to fit the nul terminator:
zsh% zle_cursorform=( edit:steady,color=\#abcdef )
Breakpoint 1, cursor_form () at termquery.c:987
987 if (s - seq)
(gdb) p s - seq
$1 = 31
fix negation of h-3 in setmstatus. this was very noticable in interactive
menu selection if you typed a long string. the entire string would be
replaced by three dots instead of just the start of it.
52750: remove ansi2knr support for old pre-ansi K&R compilers2024-03-18T19:02:34ZOliver Kiddleopk@zsh.org2024-03-18T19:02:34Zurn:sha1:57248b88830ce56adc243a40c7773fb3825cab3451212: remove STOUC() macro2022-12-16T22:28:10ZOliver Kiddleopk@zsh.org2022-12-16T22:22:33Zurn:sha1:a73c705b0c864a9ce042fca6e72e0c92d4ad8237
This served as a workaround for ancient compilers where casts to
unsigned char were broken.
46072 + 46136: Add the 'zle $widget -f nolast' syntax, to improve add-zle-hook-widget support for multiple hook functions.2020-06-27T03:09:31ZDaniel Shahafd.s@daniel.shahaf.name2020-06-18T11:42:19Zurn:sha1:0cffb0a6b3602a00cebe2bbb7537d76727892959
See workers/46004 for the use-case.
44215: Maintain LASTWIDGET across reset-prompt.2019-04-10T08:41:04ZRoman Perepelitsaroman.perepelitsa@gmail.com2019-04-09T18:45:37Zurn:sha1:c5519372808d78519e1bac2db165d19a34534f74
This avoids side effects of asynchronous notifications.
42760: move stack variable outside while loop scope as it is accessed in the while condition2018-05-13T07:51:05ZOliver Kiddleokiddle@yahoo.co.uk2018-05-13T07:51:05Zurn:sha1:f0c2cf8607dd055f2b8aaa98664f7328108f2c6542501: avoid out of bound pointer (as 42487)2018-03-24T06:22:10ZJun-ichi Takimototakimoto-j@kba.biglobe.ne.jp2018-03-24T06:17:37Zurn:sha1:e4a8069b329cacd6486f831bb55273f8253295b241244: Add zmodload -s option.2017-06-12T09:10:23ZPeter Stephensonpws@zsh.org2017-06-12T09:10:23Zurn:sha1:d5c22d356ba442fd5811e15cc35b5480008722f4
Doesn't complain if module is unavailable, but prints more
obscure errors.
Use existing low-level silent flag by passing through
intermediate module loading hierarchy.
40305: fix some problems redisplaying command line after interrupt.2017-01-10T19:18:52ZPeter Stephensonp.w.stephenson@ntlworld.com2017-01-10T19:18:52Zurn:sha1:34656ec2f00d6669cef56afdbffdd90639d7b465
Back off previous fix as this only covered some subset of problems.
Remaining problems happend after reset-prompt in TRAPINT.
One was in complist and is fixed by not attempting to list after
an error or interrupt.
The other was owing to not resetting clearflag when ZLE
was re-entered.
39986, 39989: improve handling of vi-repeat-change2016-11-20T22:59:48ZOliver Kiddleopk@zsh.org2016-11-20T22:54:45Zurn:sha1:cb5f100bd38a3b21739897fb4236db0700b39477
Save previous vi change and throw away a new change that fails.
Add zle -f vichange to allow shell widget to be a single change.
Fix repeat of command where numeric arguments were multiplied.
unposted: remove extra close-paren from d6a6b4ff2016-09-28T04:47:55ZBart Schaeferschaefer@zsh.org2016-09-28T04:47:55Zurn:sha1:8d04b5429ffc9a302addd7159b20f8cadffd0c4439369 (tweaked cf 39371): when calling an internal widget, set bindk because some widgets use it to determine how they should act2016-09-27T19:32:01ZOliver Kiddleopk@zsh.org2016-09-27T19:32:01Zurn:sha1:d6a6b4ff3a681dd72508aad21eb8ebe34147bc5eunposted: fix typo in comment2016-08-07T03:07:26ZBarton E. Schaeferschaefer@zsh.org2016-08-07T03:07:26Zurn:sha1:ac0dcc9a63dc2a0edc62f8f1381b15b0b5ce5da337337: Delay freeing widget until not in use.2015-12-07T14:32:52ZPeter Stephensonpws@zsh.org2015-12-07T14:32:52Zurn:sha1:0c2d823a7955981e88f7cb5b718a7081d97104f036974: fix some functions with empty argument lists2015-10-27T09:28:36ZPeter Stephensonpws@zsh.org2015-10-27T09:28:36Zurn:sha1:d45a68c5463224f43721371fb7bd4cbc24e62874unposted: define zle_usable before using it (reported in 36741)2015-10-02T18:41:53ZMikael Magnussonmikachu@gmail.com2015-10-02T18:41:49Zurn:sha1:0626be9e3c02ca9171cd4e0975c208e0c3d6ec2bunposted: zle_thingy: return a value in bin_zle_flags2015-10-01T18:24:45ZMikael Magnussonmikachu@gmail.com2015-10-01T18:24:09Zurn:sha1:fa72e547120581cdbff1b1695a47c2c19fed348736709: zle -f from inside widget to set flags and make yank start/end zle params writable2015-10-01T01:51:44ZMikael Magnussonmikachu@gmail.com2015-09-29T04:11:24Zurn:sha1:a855d7bd246ef44d5393c3088aae8214d41d2b8536522: unmetafy the argument of "zle -U"2015-09-12T23:13:01ZBarton E. Schaeferschaefer@zsh.org2015-09-12T23:13:01Zurn:sha1:8e77fcb050ed09042cc2464f804ac023c0f88b4231961: rationalise fd watching to use structure2013-11-12T20:41:06ZPeter Stephensonp.w.stephenson@ntlworld.com2013-11-12T20:41:06Zurn:sha1:2fc2bb7c17aeb7514e5d42e46bb08304480bf12531937: zle -Fw uses widget semantics for file descriptor handler2013-11-07T15:19:07ZPeter Stephensonpws@zsh.org2013-11-07T15:19:07Zurn:sha1:f77a7a5b18f0650d32e5e8dac1f1cb284a9e469030084: `zle -T tc func' for zle testing of termcap output2012-01-05T20:01:24ZPeter Stephensonpws@users.sourceforge.net2012-01-05T20:01:24Zurn:sha1:9b923cccea05b93eeade4a69694985880d5affa229891: make zle -lL with arguments work2011-11-04T14:14:26ZPeter Stephensonpws@users.sourceforge.net2011-11-04T14:14:26Zurn:sha1:45faf8f5b2758a638e0958928262ca9d2698088524853: use metafied strings for inner loops over history2008-04-20T21:17:29ZPeter Stephensonpws@users.sourceforge.net2008-04-20T21:17:29Zurn:sha1:b8ec06c870ac09d5949907640dca4c1a2b711ed524279: allow terminal changes after zle -I to be acquired by main shell2007-12-18T10:42:36ZPeter Stephensonpws@users.sourceforge.net2007-12-18T10:42:36Zurn:sha1:1ee6295909c893c55693232a12f10cd8625a726023488: tidy up module interface and documentation2007-05-29T17:01:07ZPeter Stephensonpws@users.sourceforge.net2007-05-29T17:01:07Zurn:sha1:6ab77f00ff8c4a30bf663f6e4ee39b9b23d3ef32see 23479: add initial features support for modules2007-05-28T22:57:39ZPeter Stephensonpws@users.sourceforge.net2007-05-28T22:57:39Zurn:sha1:b0c5f09169ac31855ebf0e93772bb57b9635b38022676, 22678: extend sched and make it able to run events when waiting for2006-09-10T15:24:26ZPeter Stephensonpws@users.sourceforge.net2006-09-10T15:24:26Zurn:sha1:b726ead94e911e1ce3e8b582c315b3d6f83a6eb7
input
22474: use variable argument lists to improve error message handling2006-05-30T22:35:03ZPeter Stephensonpws@users.sourceforge.net2006-05-30T22:35:03Zurn:sha1:dd5602f59b599177fb130512fc543f7efa95199022431: set WIDGET etc. more consistently when executing zle functions2006-04-25T15:00:25ZPeter Stephensonpws@users.sourceforge.net2006-04-25T15:00:25Zurn:sha1:949f5b6deefb7d4944f1b59fe2264ac0821a330422427: zle <widget> -w sets the environment for <widget>2006-04-25T10:10:49ZPeter Stephensonpws@users.sourceforge.net2006-04-25T10:10:49Zurn:sha1:a2d5ebe3c017a3f34ce2ead69110b08c2eeeb67eFixed call to undefined function zwarnname() instead of zwarnnam().2006-03-25T18:50:44ZWayne Davisonwayned@users.sourceforge.net2006-03-25T18:50:44Zurn:sha1:eafa96805bf60b89fb9b5b08ed703459ac7437b622638: MACHINES: IRIX2006-03-21T19:19:05ZPeter Stephensonpws@users.sourceforge.net2006-03-21T19:19:05Zurn:sha1:7b7905fedbd7d8b4b0791928c96682bb97057956
users/10047: zle widget -K keymap
Fix some compiler warnings and ensure that zmod gets restored2006-03-09T09:44:28ZWayne Davisonwayned@users.sourceforge.net2006-03-09T09:44:28Zurn:sha1:04ea7bae96718450bd79792da8cecd8392890f8e
properly in bin_zle_call().
Got rid of some unsigned-char/char pointer casts.2005-11-15T08:44:17ZWayne Davisonwayned@users.sourceforge.net2005-11-15T08:44:17Zurn:sha1:e79af955f0620a699b01f11b584788404ba8176721943, 21945: ZLE_UNICODE_SUPPORT -> MULTIBYTE_SUPPORT;2005-10-28T17:34:33ZPeter Stephensonpws@users.sourceforge.net2005-10-28T17:34:33Zurn:sha1:aea77152614952519351b5a52b6ec19ea7c302c2
use multibyte versions of nicechar wherever possible.
21939: new UNMETACHECK() was too ruthless2005-10-26T10:06:47ZPeter Stephensonpws@users.sourceforge.net2005-10-26T10:06:47Zurn:sha1:d7a37f48fd12d95134ae9db262f36452471c495enot yet posted; zle line screwed up on bad return from insertlastword()2005-10-23T17:42:56ZPeter Stephensonpws@users.sourceforge.net2005-10-23T17:42:56Zurn:sha1:05b6a233622031136304bbb3dfe7012d29cae7f121784: Improved character widths for formatted multibyte character output2005-09-29T17:32:34ZPeter Stephensonpws@users.sourceforge.net2005-09-29T17:32:34Zurn:sha1:046f4cf49e1a082f78b0acadadae8855db5cb37ec.f. 21590: metafy_line()/unmetafy_line() now support wide characters2005-08-10T10:56:40ZPeter Stephensonpws@users.sourceforge.net2005-08-10T10:56:40Zurn:sha1:2a888b3d5ae1f485649b811ea433f286238fd30820861: Fix statusline in Unicode, apart from isearch2005-02-24T15:32:36ZPeter Stephensonpws@users.sourceforge.net2005-02-24T15:32:36Zurn:sha1:691dd7e5294d232a7ab8327e2038f9779732fa3c20822: Initial code for Unicode/multibyte input2005-02-18T13:57:25ZPeter Stephensonpws@users.sourceforge.net2005-02-18T13:57:25Zurn:sha1:d7c13fb2c3b1b014acde9c1cb17a1e34239b9751
20823: Debugging test in stat wrong for 64-bit systems
20330: rationalise zle return statuses2004-09-08T15:23:47ZPeter Stephensonpws@users.sourceforge.net2004-09-08T15:23:47Zurn:sha1:65bbf722d9061b99c70722fc613ca612d4bd48d620303: zle -I test and running zle widgets in traps2004-09-02T14:34:33ZPeter Stephensonpws@users.sourceforge.net2004-09-02T14:34:33Zurn:sha1:fb7907257503b2c8915d3623c694bfb21122b7dfMarked unused parameters with the new UNUSED() macro.2004-06-02T22:14:25ZWayne Davisonwayned@users.sourceforge.net2004-06-02T22:14:25Zurn:sha1:fb0937a69eb38e744577aa94a6338135f6c1c9b419281: zle-line-init special widget2003-12-12T22:53:27ZPeter Stephensonpws@users.sourceforge.net2003-12-12T22:53:27Zurn:sha1:1e212cbedcec984ce8bd6f89aa5db8e0b628435ba la 19209: zcalloc -> zshcalloc2003-10-29T19:17:30ZPeter Stephensonpws@users.sourceforge.net2003-10-29T19:17:30Zurn:sha1:815bc92148939ce369585c59d3af730f6983384417582: Improved option argument handling.2002-08-27T21:10:30ZPeter Stephensonpws@users.sourceforge.net2002-08-27T21:10:30Zurn:sha1:9634760d5eae4e8618e4b9ed9752d7305b3695a9
unposted: Updated version to 4.1.0-dev-6 because of interface change.
fix default completion module loading, use compctl if it hasn't been loaded already and no completion widgets have been defined (17567)2002-08-20T12:28:05ZSven Wischnowskywischnow@users.sourceforge.net2002-08-20T12:28:05Zurn:sha1:1229d05c19453a344d696f3fc95fad4115b075b517304: tweak to tweak the tweaked tweak for zle -I in 173012002-06-07T18:04:06ZPeter Stephensonpws@users.sourceforge.net2002-06-07T18:04:06Zurn:sha1:b673918c0ffd358a31353c86c1084286741f730617301: improve zle -I.2002-06-07T10:57:24ZPeter Stephensonpws@users.sourceforge.net2002-06-07T10:57:24Zurn:sha1:37199039b2666815e42072ba934001fadb53b18317295: `zle -F' failed because of bad test2002-06-05T21:12:08ZPeter Stephensonpws@users.sourceforge.net2002-06-05T21:12:08Zurn:sha1:9c8b79b993057c8a146016e734eeb72571ea413d17141 plus mods: add `zle -F fd handler' feature.2002-05-21T11:10:13ZPeter Stephensonpws@users.sourceforge.net2002-05-21T11:10:13Zurn:sha1:afe1b00e16c7efc5c93c958fa4f357325977a2a115734: zle -K option to select a keymap, and zle KEYMAP parameter to2001-09-03T01:39:19ZAndrew Mainzefram@users.sourceforge.net2001-09-03T01:39:19Zurn:sha1:b73d71105eaca6ae001a3e836ab08406ef188789
examine the current selection.
Sven: 13108: Handle traps synchronously2000-11-11T19:50:27ZPeter Stephensonpws@users.sourceforge.net2000-11-11T19:50:27Zurn:sha1:c292a3ae50bd0605b015f80266418e391c3c10fe
pws: 13109, 13111: clear up zle display when output produced in trap.
fix zle widget -n num with num>9 (12238)2000-07-13T09:11:54ZSven Wischnowskywischnow@users.sourceforge.net2000-07-13T09:11:54Zurn:sha1:663ecf8e1237fcc32d2d1951f25e6c3c6ada08b1Initial revision1999-04-15T18:05:38ZTanaka Akiraakr@users.sourceforge.net1999-04-15T18:05:38Zurn:sha1:e74702b467171dbdafb56dfe354794a212e020d9