zsh/Functions/VCS_Info/VCS_INFO_set-patch-format, branch declarednull [no description] http://git.sudomsg.com/mirror/zsh/atom?h=declarednull 2020-08-09T08:07:01Z 47303: vcs_info hg: Fix changing the expansion of %g (hook_com[guards]) in the set-patch-format hook (regression from workers/40480). 2020-08-09T08:07:01Z Daniel Shahaf d.s@daniel.shahaf.name 2020-08-08T07:29:34Z urn:sha1:5448e1611d2cc4cb436fedfc3e7ff0f1ebfc766b To reproduce, go to a hg repository with active mq guards and configure vcs_info as follows: zstyle '*' get-unapplied true zstyle ':vcs_info:*set-patch-format*' hooks f zstyle '*' patch-format '[%g : %G]' zstyle '*' nopatch-format '[%g : %G]' zstyle '*' formats '%m' +vi-f () { hook_com[guards]+=XXX } The regression was first released in 5.3.1-test-2, over three years ago. 43620 (tweaked): vcs_info git: Reverse the order patches are passed to gen-unapplied-string in. 2018-10-08T13:44:40Z Daniel Shahaf d.s@daniel.shahaf.name 2018-10-07T17:46:43Z urn:sha1:e38f15f8ff23651a8c4ef9fc394de7be93eb620f This is an incompatible change; see README for details. Tweaks (relative to posted version): tweaked README, removed scalpel (debug print). 40492: vcs_info: Escape '%' signs in payloads. 2017-02-09T15:24:04Z Daniel Shahaf d.s@daniel.shahaf.name 2017-02-05T08:28:13Z urn:sha1:ecd88284f358cbcd787757184bbf8704779cab1a Test case: a patch whose subject is '%Sfoo%sbar'. ('S' and 's' are expandos both in prompts and in the 'formats' style.) 40480: vcs_info set-patch-format: Eliminate the remaining code duplication. 2017-02-03T18:14:01Z Daniel Shahaf d.s@daniel.shahaf.name 2017-02-01T19:05:45Z urn:sha1:33c0a104482a0299d5d065b88c180ea6975269c0 40479: vcs_info set-patch-format: Prepare for more code sharing between the callers. 2017-02-03T18:14:00Z Daniel Shahaf d.s@daniel.shahaf.name 2017-02-01T19:05:44Z urn:sha1:9211d7f2777abaedfacf98812104d579c3b861f3 This changes hook invocation order in the hg backend. 40478: vcs_info set-patch-format: Guard against empty variable elision. 2017-02-03T18:13:58Z Daniel Shahaf d.s@daniel.shahaf.name 2017-02-01T19:05:42Z urn:sha1:3a1756b7280e42d14de58ad90990cf4b04731b3b 40403/0004: vcs_info set-patch-format helper: Part #4. 2017-01-25T04:22:32Z Daniel Shahaf d.s@daniel.shahaf.name 2017-01-23T18:15:35Z urn:sha1:2854a67e09748a2e6f4e1d8a73bc463bad4cbd4e This also fixes the %a (${hook_com[all-n]}) expando in the hg backend: before this change, it counted only unapplied changes. 40403/0003: vcs_info set-patch-format helper: Part #3. 2017-01-25T04:22:32Z Daniel Shahaf d.s@daniel.shahaf.name 2017-01-23T18:15:35Z urn:sha1:edd9798de765049a904e0afa830b191d1932087d 40403/0002: vcs_info set-patch-format helper: Part #2. 2017-01-25T04:22:31Z Daniel Shahaf d.s@daniel.shahaf.name 2017-01-23T18:15:35Z urn:sha1:270285733442a46cd157ade4600e4073e255a563 Not all callers reset ${hook_com}, but those that don't, immediately overwrite it a few lines later. 40403/0001: vcs_info set-patch-format helper: Part #1. 2017-01-25T04:22:30Z Daniel Shahaf d.s@daniel.shahaf.name 2017-01-23T18:15:35Z urn:sha1:0ea1957608a6b496fc244078ce9e24f00327aba9