zsh, branch 5.9

unposted: Move a new incompatibility notice.

2020-03-07T21:50:26Z

The change in question was (deliberately) not merged to master before the 5.8 release. Therefore, it is a "post 5.8" change, even though it was written when 5.7.1 was the latest release.

Merge remote-tracking branch 'origin/master' into 5.9

2020-03-07T21:36:46Z

* Test/D02glob.ztst: On the "unreadable directories can be globbed (users/24619, users/24626)" test, resolve conflicts by removing the Cygwin-only skip that has been added in master, since the test is passing on this branch. This effectively reverts workers/45492. See discussion starting in workers/45504. * origin/master: unposted: Remove 'sgi', as that OpenBSD port has been discontinued. 45509: fix typos in B01cd.ztst 45490 (+45495 and a test): refactor rlimits.c github #49: Fix typo: longson should be loongson users/24710: Fix job control problem with sudo. 45492: skip test added by users/24633 on Cygwin 45488: COMP_WORDS for bash need "$@"-style quoting 45487: Missing mod_export declarations for AIX 45447: Complete vcs_info_hookadd and vcs_info_hookdel. Expose _vcs_info_hooks as a top-level helper function. 45463: test: kill: Document why we use SIGURG 45453: builtins: kill: Do not signal current process group when pid is empty 45452: builtins: kill: Add `kill ''` regression test with explicit sigspec 45451: builtins: kill: Add basic test suite github #48/0002: vcs_info git: properly detect bare repositories github #48/0001: vcs_info git: avoid warnings in bare repositories unposted: Post-release version bump unposted: Release 5.8 CVE-2019-20044: Update change log for preceding commits Update NEWS/README Add unsetopt/PRIVILEGED tests Clean up error-message white space Improve PRIVILEGED fixes (again) Improve PRIVILEGED fixes Drop privileges securely unposted: V01zmodload: Fix failing test from workers/45385 45423: _su: Improve arg handling, shell look-ups unposted: _zip: Recognise '--' 45385: Add a test for 'zmodload -Fa' preemptively disabling ("blacklisting"?) features. unposted: Test release: 5.7.1-test-3 zsh/system: Fix infinite loop in sysread _diff_options: Restore -w completion lost in workers/43351 unposted: Fix ChangeLog typo. 45368: Add tests for workers/45367's issue about double slashes in 'cd -P' and /home/daniel/in/zsh. 45373: Fix ERR_EXIT bug in else branch of if. 45372: Record a symlink loop bug involving :P 45365: _git: Fix __git_recent_branches for the case when a commit has an empty message 45343: Queue signals around arithmetic evaluations 45344: Document where third-party completion functions should be installed. 45345: internal: ztst.vim: Fix highlighting of zsh comments in test payload unposted: internal: Add some comments and fix indentation. No functional change. 45340: internal: Document the difference between paramtab and realparamtab. 45332: _git: add completion for git-version _brace_parameter: add missing \ Conflicts: ChangeLog Test/D02glob.ztst Test/V01zmodload.ztst

unposted: Fix trailing whitespace in test expectations.

2020-03-07T21:32:57Z

unposted: Remove 'sgi', as that OpenBSD port has been discontinued.

2020-03-06T14:00:34Z

See https://www.openbsd.org/sgi.html and discussion on github PR #49.

45509: fix typos in B01cd.ztst

2020-03-06T11:14:21Z

45490 (+45495 and a test): refactor rlimits.c

2020-03-06T11:12:06Z

Use a table of known resouces instead of generating rlimits.h by rlimits.awk.

github #49: Fix typo: longson should be loongson

2020-03-05T15:44:12Z

users/24710: Fix job control problem with sudo.

2020-02-27T20:42:16Z

If we use kill to test for continued existence of a process group, we should check on failure that the error is ESRCH, as EPERM indicates the group still has memebers but running privileged so should be left alone.

45492: skip test added by users/24633 on Cygwin

2020-02-27T07:08:13Z

45488: COMP_WORDS for bash need "$@"-style quoting

2020-02-25T09:55:28Z

45487: Missing mod_export declarations for AIX

2020-02-24T10:55:48Z

45447: Complete vcs_info_hookadd and vcs_info_hookdel. Expose _vcs_info_hooks as a top-level helper function.

2020-02-19T10:18:30Z

45463: test: kill: Document why we use SIGURG

2020-02-18T19:35:18Z

See discussion in workers/45460.

45453: builtins: kill: Do not signal current process group when pid is empty

2020-02-18T12:59:53Z

The following case was encountered in the wild: % zsh; echo "$?" % trap 'exit 5' TERM % kill '' 5 This behaviour seems more likely to be the result of bugs in programs (e.g. `kill -9 "$unsetvar") rather than being desirable behaviour to me. It also seems unintentional judging by the code and documentation, since it comes about as a result of the fact that: - `isanum` returns true for empty strings (since an empty string technically only consists of digits and minuses...); - `atoi`, when passed a pointer to an invalid number, returns 0; - `kill(0, signal)` sends the signal in question to all processes in the current process group. There are (at least) two ways to solve this issue: 1. Add special handling to `kill` to avoid this case. See this patch[0] for a version that does that. 2. Change how isanum behaves. Since the only two call sites that use it both seem like they should handle the case where the input char array is empty, that seems like a reasonable overall change to me.[1] After this patch: % trap 'exit 5' TERM % kill '' kill: illegal pid: The regression test for `kill` without a sigspec is also included in this commit, as previously it's not possible to test it trivially as it would still kill the test runner in expected-to-fail mode; see discussion in workers/45449. 0: workers/45426: https://www.zsh.org/mla/workers/2020/msg00251.html 1: The other call site using isanum() is the fg builtin, but in that case we just fail later since we can't find any job named '', so no big deal either way. It's the kill case which is more concerning.

45452: builtins: kill: Add `kill ''` regression test with explicit sigspec

2020-02-18T12:59:52Z

The version without a sigspec can't be added yet because it would still kill the test runner even in expected-to-fail mode; see workers/45449 for discussion. For the same reason, we use a signal which is non-fatal by default and unlikely to be sent by someone else, SIGURG, to do the expected-to-fail case prior to the fix.

45451: builtins: kill: Add basic test suite

2020-02-18T12:59:51Z

This is not totally comprehensive, but at least it's a start for the core functionality. In the next commits, we'll also use this base to add some regression tests.

github #48/0002: vcs_info git: properly detect bare repositories

2020-02-17T10:03:08Z

We currently detect Git repositories by finding the top level of the working tree, and if we fail to detect it, assume that we're not in a repository. However, there's a case we don't consider: a bare repository. Let's detect if the user is in a bare repository by checking if gitdir is set, and if so, using that if there is no working tree. We now detect bare Git repositories with vcs_info, as expected.

github #48/0001: vcs_info git: avoid warnings in bare repositories

2020-02-17T10:02:27Z

Git 2.25 introduced a change to how git rev-parse --show-toplevel behaves. Traditionally, it succeeded with no output if the user was in a bare repository. Now it dies, printing an error to standard error. Consequently, when the user is in a bare repository with a newer Git, vcs_info prints noisily to standard error. While this is functionally harmless, it is annoying for the shell to print messages from Git every time the prompt is printed, so let's silence the error message.

unposted: Post-release version bump

2020-02-14T22:11:03Z

unposted: Release 5.8

2020-02-14T22:08:55Z

CVE-2019-20044: Update change log for preceding commits

2020-02-14T22:08:29Z

Update NEWS/README

2020-02-14T22:06:58Z

Add unsetopt/PRIVILEGED tests

2020-02-14T22:06:58Z

Clean up error-message white space

2020-02-14T22:06:57Z

Improve PRIVILEGED fixes (again)

2020-02-14T22:06:57Z

* Pass RGID instead of passwd GID to initgroups() * Clean up #ifdefs, avoid unnecessary checks * Flatten conditions

Improve PRIVILEGED fixes

2020-02-14T22:06:57Z

- Fix retval handling in bin_setopt() - Don't skip_setuid / skip_setgid. It's not our place to optimize away noops (that might not even _be_ noops; they might change the saved uid…). - Remove HAVE_* guard checks around functions that are used unguarded elsewhere. - Use bsd-setres_id.c from OpenSSH to provide setresuid() / setresgid() everywhere, and thus simplify the ifdef soup. Fix some preëxisting bugs in the macro definitions of setuid() (do we still need that one?). - Fix zwarning() format codes for variadic arguments type safety - Restored a comment from HEAD - Fix failure modes around initgroups() - Compared privilege restoration code with OpenSSH's permanently_drop_uid() and updated as needed - Add E01 PRIVILEGED sanity checks

Drop privileges securely

2020-02-14T22:06:57Z

unposted: V01zmodload: Fix failing test from workers/45385

2020-02-14T21:55:52Z

45423: _su: Improve arg handling, shell look-ups

2020-02-14T15:42:12Z

Differences from ML post: * Properly fix escaping issue with $usr (needs unescaped first) * Make $shell emptiness check easier to read (per feedback)

unposted: _zip: Recognise '--'

2020-02-07T20:05:48Z

45385: Add a test for 'zmodload -Fa' preemptively disabling ("blacklisting"?) features.

2020-02-07T12:44:53Z

unposted: Test release: 5.7.1-test-3

2020-02-06T20:01:53Z

zsh/system: Fix infinite loop in sysread

2020-02-06T19:42:32Z

_diff_options: Restore -w completion lost in workers/43351

2020-02-06T19:24:00Z

unposted: Fix ChangeLog typo.

2020-02-06T05:55:05Z

45368: Add tests for workers/45367's issue about double slashes in 'cd -P' and /home/daniel/in/zsh.

2020-02-03T07:09:30Z

45373: Fix ERR_EXIT bug in else branch of if.

2020-02-02T18:05:47Z

The flags need resetting for this branch otherwise e.g. command substitution with non-zero status doesn't cause exit.

45372: Record a symlink loop bug involving :P

2020-02-02T07:36:41Z

45365: _git: Fix __git_recent_branches for the case when a commit has an empty message

2020-02-02T07:32:14Z

45343: Queue signals around arithmetic evaluations

2020-01-29T09:02:49Z

The queueing added in execarith() in 45083 is reverted since the callee does this now.

45344: Document where third-party completion functions should be installed.

2020-01-29T09:02:34Z

45342: Add tests for interaction between autoloadable parameters and module loading.

2020-01-29T08:30:47Z

45345: internal: ztst.vim: Fix highlighting of zsh comments in test payload

2020-01-28T09:24:34Z

unposted: internal: Add some comments and fix indentation. No functional change.

2020-01-26T03:46:00Z

45340: internal: Document the difference between paramtab and realparamtab.

2020-01-23T03:21:36Z

45332: _git: add completion for git-version

2020-01-19T23:32:37Z

Signed-off-by: Eitan Adler

_brace_parameter: add missing \

2020-01-19T15:11:14Z

45313: _git: Support completion from outside of a worktree when --git-dir/--work-tree are specified on the command line

2020-01-17T21:52:45Z

Revised version of workers/41523.

45304: Do execute the always block even when the try/always block itself is the last command.

2020-01-16T18:29:13Z

Fixes the test added in the previous commit (workers/45305).

Merge branch 'master' into 5.9

2020-01-16T18:21:41Z

* master: 45305: Add an XFail test: The exec-last-command optimization is applied to try/always. 45307: zstyle docs: Unoverload a placeholder variable name. 45306: zstyle docs: Introduce the first synopsis in the same way as all others: with an item()(). unposted: docs: Fix a cross-reference.

45305: Add an XFail test: The exec-last-command optimization is applied to try/always.

2020-01-16T18:21:11Z

45307: zstyle docs: Unoverload a placeholder variable name.

2020-01-16T18:18:17Z

Use 'pattern' to refer to things matched against contexts and 'metapattern' to refer to things matched against patterns.

45306: zstyle docs: Introduce the first synopsis in the same way as all others: with an item()().

2020-01-16T18:18:14Z

unposted: docs: Fix a cross-reference.

2020-01-16T16:32:39Z

45292: D02glob: Add regression test for macOS stat(2) misbehaviour

2020-01-16T01:31:16Z

On macOS, a privileged stat(2) call can erroneously treat files as directories, which can produce unexpected glob results. This was reported at workers/42891. A side-effect of the change from workers/45291 is that it seems to work around this issue, at least in the obvious cases

45291: A glob with a trailing slash will now match unreadable/unexecutable directories.

2020-01-16T01:20:33Z

Merge remote-tracking branch 'origin/master' into 5.9

2020-01-15T22:49:09Z

Right now, as we're preparing to tag the 5.8 release, the 5.9 branch is maintained as a topic branch off master. * origin/master: 45287: zshexpn: Describe parameter elision and add some introductory prose 45302: bin_umask(): Queue signals around umask(). users/24656: docs: Add an example of setting and querying zstyles users/24659: Cross-ref doc for matchers. 45296: D02glob: Clean up after test from users/24633 45290: New helper script for listing XFail tests. users/24633: Add an xfail test for users/24619. unposted: additional typo fix 45280: _git: add -local variants users/24628 (fixed): More doc for selectw-word-style widgets. 45266: Fix losetup completion, broken in da085b7a20729401c725f91ae930200d0deda64f (41720). unposted: Fix punctuation. use /dev/fd on Cygwin for process substitution unposted: Two additional typo fixes. Fix typos reported by codespell in shell code Fix typos reported by codespell in Src/ 45269: Fix misspellings in completions and elsewhere. 45261: _gcc: Detect clang-as-gcc unposted: internal: Remove Vim modeline that interferes with ztst.vim. unposted: internal: ztst.vim: Use :syn-sync to work around (#x) and "`\\\\\\\\`" confusing the highlighting. unposted: internal: zyodl.vim: Support glob qualifiers in example()'s unposted: internal: zyodl.vim: Support yodl comments. github #44: Allow completion for picocom to list symlinks to character devices 45245: _gcc: add some clang specific warnings 45231: _rsync: When completing remote modules, ignore more of the motd. unposted: _tac: Eliminate superfluous variable 45226: _man: Improve completion of file paths 45184: Clarify documentation of %-sequences understood by compadd -[Xx] 45239: Remove 'appendhistory' from zsh-newuser-install 45218: add more options to swaks completion 45196: fix completion after make -C, allowing for -C being used multiple times unposted (after 45183): Fix yodl error: "contrib.yo:4457: No macro: back(...)". 45181: Fix workers/45164: ${(S)%%} will now consider the empty string as a potential match. 45183: Improve documentation examples unposted: Add some tests for ${(S)}, including a regression test for workers/45164. 45169/0002 (tweaked for trailing newlines): Add an expected-to-fail test for workers/44007. 45169/0001: In the test suite, allow test cases to be marked as expected to fail. users/24582 + users/24583: Add regression tests for the previous commit. 24581: Fix array assignments in shell word splitting and completion. 45160: zshexpn: Expand documentation of (S) 45150 + 45152: zshexpn: Use a more minimal example in the documentation of (#b). unposted: internal: Vim ztst support: Add an ftplugin in addition to the syntax highlighter. 45130: _multi_parts: Always pass -f to compadd if given by caller unposted: zerrmsg(): Fix macro guard missed in previous commit unposted: ChangeLog for last commit internal: Allow %L in zerrmsg() in non-debug builds, too.

45288: _git: Complete bisect/new as well as bisect/bad.

2020-01-15T22:41:25Z

Also, complete the bisect/old-$commithash ref names.

45287: zshexpn: Describe parameter elision and add some introductory prose

2020-01-15T22:35:09Z

45302: bin_umask(): Queue signals around umask().

2020-01-15T19:49:45Z

Otherwise, a signal handler might create files while the temporary umask is in effect.

users/24656: docs: Add an example of setting and querying zstyles

2020-01-14T17:42:36Z

users/24659: Cross-ref doc for matchers.

2020-01-14T14:00:03Z

45296: D02glob: Clean up after test from users/24633

2020-01-13T23:43:51Z

45290: New helper script for listing XFail tests.

2020-01-13T22:48:55Z

users/24633: Add an xfail test for users/24619.

2020-01-12T22:14:10Z

unposted: additional typo fix

2020-01-11T16:41:14Z

45280: _git: add -local variants

2020-01-11T16:37:44Z

Technically all timezone formats support the "-local" suffix but it is not meaningful for all of them. As such just list out the specific formats which it does. Also adjust the 'default' description

users/24628 (fixed): More doc for selectw-word-style widgets.

2020-01-11T14:07:19Z

Add example of how to add a new binding for a widget that fixes a particular word behaviour using styles.

45266: Fix losetup completion, broken in da085b7a20729401c725f91ae930200d0deda64f (41720).

2020-01-10T12:46:38Z

unposted: Fix punctuation.

2020-01-10T12:46:32Z

use /dev/fd on Cygwin for process substitution

2020-01-10T09:46:37Z

unposted: Two additional typo fixes.

2020-01-09T13:59:05Z

Fix typos reported by codespell in shell code

2020-01-09T13:51:08Z

Fix typos reported by codespell in Src/

2020-01-09T13:49:55Z

45269: Fix misspellings in completions and elsewhere.

2020-01-09T13:42:02Z

45261: _gcc: Detect clang-as-gcc

2020-01-08T23:54:46Z

unposted: internal: Remove Vim modeline that interferes with ztst.vim.

2020-01-07T19:37:41Z

As an alternative, one can use: autocmd BufRead,BufNewFile **/*.ztst setfiletype zsh (But see Util/ztst-syntax.vim and Util/ztst-ftplugin.vim for an alternative.)

unposted: internal: ztst.vim: Use :syn-sync to work around (#x) and "`\\\\\\\\`" confusing the highlighting.

2020-01-07T19:37:41Z

unposted: internal: zyodl.vim: Support glob qualifiers in example()'s

2020-01-07T19:37:41Z

unposted: internal: zyodl.vim: Support yodl comments.

2020-01-07T19:37:40Z

github #44: Allow completion for picocom to list symlinks to character devices

2020-01-07T14:55:46Z

45245: _gcc: add some clang specific warnings

2020-01-07T04:01:09Z

45246: Make --disable-multibyte warn, since the test suite fails in that configuration.

2020-01-06T14:05:21Z

45213: Make --enable-gdbm default to false, rather than default to true with an unavoidable warning.

2020-01-06T02:29:30Z

45231: _rsync: When completing remote modules, ignore more of the motd.

2020-01-06T02:28:54Z

We cannot use the --no-motd option because it inhibits the modules listing. We cannot look for a blank line because there will not be a blank line if the "motd file" does not end with a newline. Looking for tabs is an improvement. Any tabs in the motd will still cause extraneous matches, but there's nothing we can do about that. While here, show the modules in the order listed.

unposted: _tac: Eliminate superfluous variable

2020-01-05T20:51:04Z

45226: _man: Improve completion of file paths

2020-01-05T18:13:01Z

45184: Clarify documentation of %-sequences understood by compadd -[Xx]

2020-01-05T18:04:46Z

45239: Remove 'appendhistory' from zsh-newuser-install

2020-01-05T17:50:33Z

It is on by default, and new users are unlikely to want to change it.

45218: add more options to swaks completion

2020-01-03T22:02:52Z

45196: fix completion after make -C, allowing for -C being used multiple times

2020-01-03T22:01:00Z

unposted (after 45183): Fix yodl error: "contrib.yo:4457: No macro: back(...)".

2020-01-02T16:08:51Z

45181: Fix workers/45164: ${(S)%%} will now consider the empty string as a potential match.

2020-01-02T16:00:11Z

45183: Improve documentation examples

2020-01-02T04:02:48Z

unposted: Add some tests for ${(S)}, including a regression test for workers/45164.

2020-01-01T13:56:04Z

45169/0002 (tweaked for trailing newlines): Add an expected-to-fail test for workers/44007.

2020-01-01T13:55:39Z

45169/0001: In the test suite, allow test cases to be marked as expected to fail.

2020-01-01T13:55:39Z

See next commit for a use-case.

users/24582 + users/24583: Add regression tests for the previous commit.

2019-12-31T18:43:26Z

24581: Fix array assignments in shell word splitting and completion.

2019-12-31T18:35:06Z

Assignments after the first were not recognised as such as without the full parser the state didn't return to command position. Fix this in bufferwords() and the completion miniparser.

45160: zshexpn: Expand documentation of (S)

2019-12-31T17:22:10Z