wayland/src, branch 1.7

event-loop: Dispatch idle callbacks twice

2015-01-29T02:12:31Z

To fix a shutdown crash in weston's x11 compositor I want to move the weston X window close to an idle handler. Since idle handlers are processed at the start of an event loop, the handler that deals with window close will run at the start of the next input_loop dispatch, after which the dispatcher blocks on epoll forever (since all input events that will ever occur have been consumed). Dispatching idle callbacks both at the start and end of event-loop processing will prevent this permanent blocking. Note that just moving the callback dispatch could theoretically result in an idle callback being delayed indefinitely while waiting for epoll_wait() to complete. Callbacks are removed from the list when they're run, so the second dispatch won't result in any extra calls. Signed-off-by: Derek Foreman Reviewed-by: Giulio Camuffo Reviewed-by: Bryce Harrington

client: unref or destroy proxy when releasing queue

2015-01-28T17:17:19Z

When we release event queue with queued events, we can leak proxies in some cases. Signed-off-by: Marek Chalupa Reviewed-by: Daniel Stone

client: release display queue in wl_display_disconnect()

2015-01-28T17:17:16Z

Don't leak events, not even on exit Signed-off-by: Marek Chalupa Reviewed-by: Daniel Stone

scanner: Fix header generation for server protocols

2015-01-27T11:18:36Z

Server protocols headers should include wayland-server.h, instead of wayland-util.h. Otherwise they're not useable with C++ compiler unless wayland-server.h was included earlier. Signed-off-by: Mariusz Ceier Reviewed-by: Daniel Stone

cosmetic: Cleanup trailing whitespace

2015-01-26T19:30:57Z

cosmetic: Move the deprecated functions back to the end of the file

2015-01-26T19:29:03Z

There are functions below the "Deprecated functions below" comment that are not deprecated. Move the deprecated functions back down, and add a comment at the end of the file to try to keep this from happening again. Signed-off-by: Derek Foreman

doc: made functions taking wl_event_queue arg belong to wl_event_queue

2015-01-24T02:44:57Z

The fact that these functions take both a display and queue argument is I think historical, and they really are methods on the queue. Also added some docs for wl_display_prepare_read_queue. Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington

doc: Remove wl_map from documentation

2015-01-24T02:44:56Z

This object is only in wayland-private.h so it's methods should not be in the documentation. Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington

doc: Remove deprecated functions from documentation

2015-01-24T02:44:55Z

Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington

doc: add missing \memberof to wl_display_get_protocol_error

2015-01-24T02:44:54Z

Reviewed-by: Derek Foreman Reviewed-by: Bryce Harrington

server: Use existing id variable when inserting created object

2015-01-24T02:20:41Z

We already have the id variable there and it makes it slightly easier to read. Signed-off-by: Jonas Ådahl Reviewed-by: Bryce Harrington

client: update documentation about threading

2014-12-09T16:05:04Z

Remove out-dated documentation and add few more words about this topic. v2. replace a paragraph by better explanation from Pekka Paalanen fix other notes from reviewing v3. fix typo v4. fix flags for poll in an example add wl_display_cancel_read() to another example (so that user sees that it should be used) move proper use of wl_display_prepare_read before the explanation why it is wrong to use wl_display_displach Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen Reviewed-by: Daniel Stone

client: update obsolete comments

2014-12-09T16:03:35Z

1) there is nothing like main thread since 3c7e8bfbb4745315b7bcbf69fa746c3d6718c305 anymore, so remove it from documentation and update the doc accordingly. 2) use calling 'default queue' instead of 'main queue'. In the code we use display->default_queue, so it'll be easier the understand. 3) update some obsolete or unprecise pieces of documentation v2. Not only remove out-of-date comment, but fix/remove more things across the wayland-client.[ch] v3. fixes (rephrasing unclear paragraphs etc.) according to Pakka Paalanen notes (thanks) Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen Reviewed-by: Daniel Stone

scanner.c: Use WL_PRINTF instead of attribute((format(printf)))

2014-11-28T10:37:20Z

Signed-off-by: Seedo Eldho Paul

doc: fixed grammar and a typo

2014-11-27T14:00:16Z

Signed-off-by: Derek Foreman

doc: Removed extra indentation from wl_list code sample

2014-11-26T11:34:26Z

This is a minor documentation fix. I did not see any asterisks in the output as reported by Pekka Paalanen. Using doxygen 1.7.6.1. Reviewed-by: Pekka Paalanen

doc: Removed \ref when it refers to the subject the text is attached to

2014-11-25T14:38:59Z

This does not make a difference to doxygen output but may help other document generators not make redundant links. Reviewed-by: Bryce Harrington

doc: fixed a typo

2014-11-25T14:38:11Z

Reviewed-by: Bryce Harrington

v4 doc: fixed reference to non-existent function

2014-11-25T14:36:57Z

(Fixed to remove accidental commit of another change) After some feedback from Marek Chalupa I decided to just remove this. There were suggestions about warning about multiple threads but it appears this would be true for many of these functions and thus it would be misleading to mention multiple threads only here (as it would imply that multiple threads work for other functions which is not true, I think). Acked-by: Marek Chalupa

doc: Added \code tags around sample code in doxygen comments

2014-11-25T14:27:57Z

Also removed \comment and used C++ comments. There does not appear to be any other way to put comments into code samples. Reviewed-by: Bryce Harrington

server: increase listen queue to 128

2014-11-24T14:32:35Z

This will allow more than 1 simultaneous client connections to the server without the possibility of connection refused error. Signed-off-by: Imran Zaman http://utcc.utoronto.ca/~cks/space/blog/unix/ListenBacklogMeaning http://stackoverflow.com/questions/19221105/connect-with-unix-domain-socket-and-full-backlog Reviewed-by: Pekka Paalanen

client: read_events should return -1 after an error

2014-11-21T11:59:42Z

When a thread is sleeping, waiting until another thread read from the display, it always returns 0. Even when an error occured. In documentation stands: "return 0 on success or -1 on error. In case of error errno will be set accordingly" So this is a fix for this. Along with the read_events, fix a test so that it now complies with this behaviour (and we have this tested) Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen

gitignore: adpat to scanner and protocol path changes

2014-11-19T14:35:49Z

Since commit 4c163b9b001bd93aaf97d7e962873a379eb90bfd, wayland-scanner is built in top builddir instead of src, and protocol files are generated in protocol subdir instead of src. Protocol files generated in the new path are already properly ignored in the toplevel gitignore file. Signed-off-by: Olivier Blin Reviewed-by: Pekka Paalanen

connection: abort if a listener function is NULL

2014-11-12T12:00:38Z

Signed-off-by: Ryo Munakata Reviewed-by: Pekka Paalanen

Remove useless semicolon.

2014-11-12T10:48:06Z

Signed-off-by: Carlos Olmedo Escobar Reviewed-by: Marek Chalupa

doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

2014-11-11T11:30:02Z

Signed-off-by: Srivardhan Hebbar [Pekka Paalanen: minor re-wording.] Signed-off-by: Pekka Paalanen

Don't document an absent parameter.

2014-11-11T10:41:44Z

Quells a doxygen warning: src/wayland-server.c:790: warning: argument 'None' of command @param is not found in the argument list of wl_display::wl_display_create(void) Signed-off-by: Bryce Harrington

scanner, client: Added more error checks when strtol function is used

2014-11-10T13:25:13Z

Signed-off-by: Imran Zaman Reviewed-by: Pekka Paalanen

wayland-server: Abort if a read from a client gives 0 length

2014-11-05T12:24:17Z

This happens on EOF if using a poll function such as select() or kqueue() which doesn’t distinguish EOF events. Currently execution should never reach the point where recvmsg() returns EOF (len == 0). Instead, epoll() will detect this and indicate EPOLLHUP, which is handled a few lines above, closing the connection. However, other event mechanisms may not be able to distinguish EOF from regular readability (in the case of select()) or inconsistently across platforms (in the case of POLLHUP). There is also the possibility of half-closed connections (shutdown(), POLLRDHUP), though this may not be an issue with Wayland. This will not cause problems if the FD polls as readable but actually is not — in that case, recvmsg() will return EAGAIN. Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto Reviewed-by: Marek Chalupa Reviewed-by: Pekka Paalanen

event-loop.c: Use correct OS abstraction function for dupfd()

2014-11-05T12:17:25Z

Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto Reviewed-by: David Fort Reviewed-by: Marek Chalupa Reviewed-by: Pekka Paalanen

connection: Fix sendmsg() on FreeBSD

2014-11-05T12:13:50Z

It expects ((msg_controllen == 0) == (msg_control == NULL)), and returns EINVAL otherwise. It can't hurt to be tidy about things on other platforms either though. See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=99356#c5 Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto Reviewed-by: Pekka Paalanen

cosmetic: convert some function returns from int to bool

2014-11-04T11:01:58Z

[Pekka Paalanen: change is_nullable_type() return value to bool.] Reviewed-by: Pekka Paalanen

connection: Leave fd open in wl_connection_destroy

2014-11-04T09:26:22Z

Calling close() on the same file descriptor that a previous call to close() already closed is wrong, and racy if another thread received that same file descriptor as a eg. new socket or actual file. There are two situations where wl_connection_destroy() would close its file descriptor and then another function up in the call chain would close the same file descriptor: * When wl_client_create() fails after calling wl_connection_create(), it will call wl_connection_destroy() before returning. However, its caller will always close the file descriptor if wl_client_create() fails. * wl_display_disconnect() unconditionally closes the display file descriptor and also calls wl_connection_destroy(). So these two seem to expect wl_connection_destroy() to leave the file descriptor open. The other caller of wl_connection_destroy(), wl_client_destroy(), does however expect wl_connection_destroy() to close its file descriptor, alas. This patch changes wl_connection_destroy() to indulge this majority of two callers by simply not closing the file descriptor. For the benefit of wl_client_destroy(), wl_connection_destroy() then returns the unclosed file descriptor so that wl_client_destroy() can close it itself. Since wl_connection_destroy() is a private function called from few places, changing its semantics seemed like the more expedient way to address the double-close() problem than shuffling around the logic in wl_client_create() to somehow enable it to always avoid calling wl_connection_destroy(). Signed-off-by: Benjamin Herr Reviewed-by: Marek Chalupa Reviewed-by: Pekka Paalanen

doc: Mark up some code examples

2014-11-03T13:09:06Z

These blocks were misformatted in normal paragraph style in the generated docs. Also, added \comment{} for comments within one code example. Signed-off-by: Benjamin Herr

scanner: Remove stray newline

2014-09-23T08:40:46Z

Signed-off-by: Jonas Ådahl

scanner: Improve XML parse error reporting

2014-09-23T08:40:46Z

Print the parse error and exit with a failure if expat can't parse the XML. Signed-off-by: Jonas Ådahl

shm: fix error in comment

2014-09-11T08:46:45Z

client: cancel read in wl_display_read_events() when last_error is set

2014-09-11T08:41:58Z

Calling wl_display_read_events() after an error should be equivalent to wl_display_cancel_read(), so that display state is consistent. Thanks to Pekka Paalanen for pointing that out. Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen

client: wake-up threads on all return paths from read_events

2014-09-11T07:22:44Z

If wl_connection_read returned EAGAIN, we must wake up sleeping threads. If we don't do this and the thread calling wl_connection_read won't call wl_display_read_events again, the sleeping threads will sleep indefinitely. Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen

client: add display_wakeup_threads function

2014-09-04T12:32:41Z

This helper function wraps the always-repeated pattern: display->read_serial++; pthread_cond_broadcast(&display->reader_cond); [Pekka Paalanen: minor whitespace and comment fixes.] Signed-off-by: Marek Chalupa signed-off-by: Pekka Paalanen

wayland-client: Initialize newly created wl_proxys to zero

2014-09-04T12:05:41Z

Up until now, newly created wl_proxys (with proxy_create or wl_proxy_create_for_id) are not initialized properly after memory allocation. The wl_display object in contrast is. To prevent giving uninitialized data to the user (e.g. user_data) an appropriate memset has been added. Also, after a memset members don't have to be explicitly initialized with zero anymore. Signed-off-by: Nils Chr. Brause Reviewed-by: Pekka Paalanen

client: check for error in wl_display_read_events

2014-08-22T12:33:49Z

This prevents from blocking shown in one display test. Also, it makes sense to not proceed further in the code of the function when an error ocurred. v2. set errno put note about the errno into wl_display_prepare_read doc check for error with mutex locked v3. set errno to display->last_error check for the error only in wl_display_read_events. It's sufficient as prevention for the hanging and programmer doesn't need to check if wl_display_prepare_read (that was previously covered by this patch too) returned an error or the queue just was not empty. Without the check, it could result in indefinite looping. Thanks to Pekka Paalanen for constant reviewing and discussing this patch. Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen

client: broadcast the right pthread_cond variable

2014-08-22T12:01:05Z

In previous commit we removed unused variables. One of them was pthread_cond_t that was formerly used when reading from display, but later was (erroneously) made unused. This patch fixes this error and is a fix for the failing test introduced few patches ago (tests: test if thread can block on error) Reviewed-by: Pekka Paalanen

client: drop unused event queue cond and list variables

2014-08-22T12:00:54Z

The wl_event_queue cond variable has been replaced by the wl_display reader_cond variable (commit 3c7e8bfbb4745315b7bcbf69fa746c3d6718c305). This cond variable is never waited for anymore, just signaled/broadcasted, and thus can be safely removed. The wl_display event_queue_list and link from wl_event_queue can be removed as well, since it was only used to iterate over the event queue list in order to broadcast the now unused cond. No regression on queue unit tests. Signed-off-by: Olivier Blin v2: fixed and rebased after 886b09c9a3a9d8672039f09fe7eaf3f2b2b012ca added signed-off-by v3: removed link from wl_event_queue Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen

client: remove unused variable

2014-08-21T11:45:03Z

display_thread variable is unused since 3c7e8bfbb4745315b7bcbf69fa746c3d6718c305 Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen

server: Don't expose wl_display as a global

2014-08-21T10:51:07Z

The idea here was that once upon a time, clients could rebind wl_display to a higher version, so we offered the ability to rebind it here. However, this is particularly broken. The existing bind implementation actually still hardcodes version numbers, and it leaks previous resources, overwriting the existing one. The newly bound resource *also* won't have any listeners attached by the client, meaning that the error and delete_id events won't get delivered correctly. Unless the client poked into libwayland internals, it also can't possibly set up these handlers correctly either, so the client will sustain errors and leak all deleted globals. Since this never worked correctly in the first place, we can feel safe removing it. Acked-by: Jason Ekstrand Reviewed-by: Pekka Paalanen

client: add a public function to make a roundtrip on a custom queue

2014-08-21T07:12:46Z

wl_display_roundtrip() works on the default queue. Add a parallel wl_display_roundtrip_queue(). Reviewed-by: Pekka Paalanen

event-loop: make signalfd non-blocking

2014-08-18T10:03:00Z

When we add more that one source to a signal, then wayland will block in wl_event_loop_dispatch. This is due to the attampt to read from signal's fd each time the source is dispatched. wl_event_loop_add_signal(loop, SIGINT, ...); wl_event_loop_add_signal(loop, SIGINT, ...); /* raise signal .. */ /* we got two fd's ready, both for the one SIGINT */ epoll_wait(...) = 2 [ for (i == 0) ] source1->dispatch() --> read(fd1); [ for (i == 1) ] source2->dispatch() --> read(fd2); /* blocking! */ Reading from fd2 will block, because we got only one signal, and it was read from fd1. Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen

scanner: Make emit_structs more explicit

2014-08-18T08:31:48Z

"is_interface" is a really terrible name for the client or server variants, and instead of checking whether we were passed the requests or the events, just pass an argument through. Reviewed-by: Marek Chalupa Reviewed-by: Pekka Paalanen

scanner: Use an enum to determine the type of thing we're writing out

2014-08-18T08:22:33Z

Reviewed-by: Marek Chalupa Reviewed-by: Pekka Paalanen

server: fix conditions for fds in wl_socket_destroy

2014-08-07T13:59:14Z

0 is also a valid fd, and needs to be closed. On error we set fd to -1. We need to also initialize fds to -1, so we do not accidentally close stdout on error. While fixing this, also remove one use-before-NULL-check. Based on the patch by Marek. Cc: Marek Chalupa Signed-off-by: Pekka Paalanen Reviewed-by: Jasper St. Pierre

server: fix error handling when adding socket

2014-08-07T13:04:24Z

When some function during adding socket fails, it must clean everything it set or we can get funky errors. This patch fixes: http://lists.freedesktop.org/archives/wayland-devel/2014-August/016331.html Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen

server: move memset after check

2014-08-07T13:03:39Z

If the malloc fails, memset would touch invalid memory. Reviewed-by: Pekka Paalanen

server: Add a simple API to find a good default display

2014-08-05T19:43:00Z

This allows compositors to easily select a good display to listen on.

server: Save the display name in the wl_socket

2014-08-05T19:43:00Z

This allows us to return the display name to the client in a new API.

server: Make get_socket_lock operate directly on the socket's lock_fd

2014-08-05T19:43:00Z

server: Split out code to initialize the socket address for a display name

2014-08-05T19:43:00Z

We'll use this to autodetect a good socket to open on.

server: Create the socket FD after taking the lock

2014-08-05T19:42:59Z

We're going to split out the lock-taking to another function so we can repetitively try locks.

server: Clean up socket destruction

2014-08-05T19:42:59Z

The code here is wrong, leaky, and inconsistent. We don't free, unlink or clean up things when we should in every error path. Centralize the data destruction so it's easier to keep track of and easier to bug fix.

wayland-client: Fix indentation

2014-08-05T19:29:01Z

doc: Fix link to wl_list_remove()

2014-07-25T04:15:05Z

Use function linking syntax instead of variable linking, to resolve two warnings: wayland-server.h:167: warning: explicit link request to 'wl_list_remove' could not be resolved wayland-server.h:188: warning: explicit link request to 'wl_list_remove' could not be resolved Signed-off-by: Bryce Harrington

client: extend error handling

2014-07-07T14:13:21Z

When an error occurs, wl_display_get_error() does not provide any way of getting know if it was a local error or if it was an error event, respectively what object caused the error and what the error was. This patch introduces a new function wl_display_get_protocol_error() which will return error code, interface and id of the object that generated the error. wl_display_get_error() will work the same way as before. wl_display_get_protocol_error() DOES NOT indicate that a non-protocol error happened. It returns valid information only in that case that (protocol) error occurred, so it should be used after calling wl_display_get_error() with positive result. [Pekka Paalanen] Applied another hunk of Bryce's comments to docs, added libtool version bump. Reviewed-by: Pekka Paalanen Reviewed-by: Bryce Harrington

connection: remove unreached code

2014-06-19T00:13:31Z

scanner: Downgrade non-increasing version error to warning

2014-05-12T22:35:04Z

Commit 99a72777f96f63e4e25dc528bb37115424adac59 introduced a new error for when the 'since' version decreases. It also reset the version for messages without a version to 1. Versioning semantics in the spec files was a little under-specified and we don't want to break projects caught in this grey zone. This commits replaces previous configure.ac as the 1.4.93 tag and the final 1.5 RC.

scanner: Generate macros for getting the 'since' version of an event

2014-05-09T21:33:20Z

This could be useful for compositors who need to be able to not send events if the client bound a version lower than the newest provided. Event version numbers are exposed as [INTERFACE_NAME]_[EVENT_NAME]_SINCE_VERSION for example wl_output.scale will have the version macro WL_OUTPUT_SCALE_SINCE_VERSION. Signed-off-by: Jonas Ådahl

scanner: Also fail when an implicitly versioned message is out of order

2014-05-09T21:31:28Z

Fail if a message with version implicitly set to 1 (i.e. not specified) comes after a message with since-version > 1. Signed-off-by: Jonas Ådahl

doc: Added API documentation for wl_display_create function.

2014-05-09T19:44:32Z

Signed-off-by: Srivardhan Hebbar

server: fix potential memleak and NULL deref

2014-05-06T22:00:31Z

If for some reason that errno is neither value (ENOMEM or EINVAL), then prior to this patch, there would be a NULL deref in wl_closure_lookup(...) at the "else if" conditional when closure == NULL. Also, closure might not be NULL but still fall into the block due to the wl_closure_lookup < 0 condition... in that case, we need to destroy the closure to avoid a memory leak. Currently, wl_connection_demarshal only sets errno to ENOMEM or EINVAL... we've already checked for ENOMEM so remove check for EINVAL (just assume it). Also, call wl_closure_destroy(...) unconditionally in the "else if" block (assume it can handle NULL closure, too, which it does right now). Signed-off-by: U. Artie Eoff

scanner: check wl_array_add result

2014-05-06T21:57:35Z

Signed-off-by: U. Artie Eoff

Avoid printing to stderr

2014-04-30T19:18:52Z

Use wl_log in the last few places where we print to stderr. Remove logging in a couple of places where we properly return an error code. https://bugs.freedesktop.org/show_bug.cgi?id=73339

Use non-blocking timerfd to prevent blocking when updating timer event sources

2014-04-25T21:38:22Z

This implements a simple fix for the blocking problem that occurs when updating a timer event source after the timer expires, but before its callback is dispatched. This can happen when another event happens during the same epoll wakeup as the timer event, and causes the read() call in wl_event_source_timer_dispatch() to block for the updated duration of the timer. We never want this read() call to block, so I believe it makes sense for the timerfd to be non-blocking, and we simply ignore the case where the read fails with EAGAIN. We still report all other errors as before, and still ignore the actual value read from the socket. With this change, the event_loop_timer_updates unit test case I submitted previously now passes, and weston appears to work as before.

connection: fix a format string typo in error message

2014-04-25T20:28:19Z

connection: Don't write past the end of the connection buffer

2014-04-21T21:51:42Z

If a message was too big to fit in the connection buffer, the code in wl_buffer_put would just write past the end of it. I haven't seen any real world use case that would trigger this bug, but it was possible to trigger it by sending a long enough string to the wl_data_source.offer request. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=69267

shm: Disallow shrinking shm pools

2014-04-07T23:01:25Z

Unused shm space will be automatically reclaimed if unused or can be explicitly returned by using fallocate FALLOC_FL_PUNCH_HOLE. https://bugs.freedesktop.org/show_bug.cgi?id=74632

scanner: Only output each forward declaration once

2014-04-03T22:58:06Z

Just sort the types and only print unique type names. We avoid using the GCC pragma.

Add WL_PRINTF attribute and annotate wl_log_func_t

2014-04-03T21:18:45Z

client: Delay EPIPE handling so we get a chance to handle error events

2014-03-26T20:28:27Z

server: Kill some unnecessary logs

2014-03-25T16:50:09Z

In order to set a logging function all the time, the output we get needs to be useful. Logging about trivial things like the socket we're using and when clients disconnect doesn't realy help anyone.

build: Move src/Makefile.am into toplevel Makefile.am

2014-03-07T19:50:59Z

connection: Use wl_log to report errors

2014-02-18T22:45:45Z

In some cases, like Xwayland, stdout and stderr are redirected to /dev/null, losing us valuable information, while wl_log can be overridden, allowing us to send it to a log file instead. This can help debugging immensely.

scanner: Add GCC pragmas to disable -Wredundant-decls

2014-02-18T22:28:08Z

The code very intentionally emits a lot of redundant declarations to simplify the scanner code. Somebody building with -Wredundant-decls would have compile errors, so emit special pragmas to turn those warnings off. These pragmas should be ignored outside of gcc/clang.

wayland-client: Set a proper errno

2014-02-18T21:39:59Z

errno is supposed to be positive, not negative. It seems that everything else that calls display_fatal_error() calls it with a positive error code, so do it here as well.

client: Queue display events on private queue and always dispatch

2014-02-08T00:50:50Z

The wl_display events (error and delete_id) need to be handled even if the default queue doesn't get dispatched for a while. For example, a busy EGL rendering loop hits wl_display.sync every eglSwapBuffers() and we need to process the delete_id events to maintain the object ID data structure. As it is, that doesn't happen, but with this change we special case wl_display events. We put them on a custom, private queue and when dispatching events, we always dispatch display_queue events first. The wl_display proxy should still be the default_queue, so that objects created from wl_display requests get assigned to that.

client: Rename display->queue to default_queue

2014-02-08T00:00:21Z

We'll add a new queue next, so rename the default queue first.

Make default log handler print to stderr

2014-02-07T23:57:07Z

On the client side we log fatal errors before we exit. If a client doesn't set a log handler, it's hard to figure out what goes wrong.

Rename wl_debug to debug_server/client

2014-02-06T04:54:33Z

Signed-off-by: Jason Ekstrand

Don't deref the sample pointer in the wl_container_of macro

2014-02-06T01:21:43Z

The previous implementation of the wl_container_of macro was dereferencing the sample pointer in order to get an address of the member to calculate the offset. Ideally this shouldn't cause any problems because the dereference doesn't actually cause the address to be read from so it shouldn't matter if the pointer is uninitialised. However this is probably technically invalid and could cause undefined behavior. Clang appears to take advantage of this undefined behavior and doesn't bother doing the subtraction. It also gives a warning when it does this. The documentation for wl_container_of implies that it should only be given an initialised pointer and if that is done then there is no problem with clang. However this is quite easy to forget and doesn't cause any problems or warnings with gcc so it's quite easy to accidentally break clang. To fix the problem this changes the macro to use pointer - offsetof(__typeof__(sample), member) so that it doesn't need to deref the sample pointer. This does however require that the __typeof__ operator is supported by the compiler. In practice we probably only care about gcc and clang and both of these happily support the operator. The previous implementation was also using __typeof__ but it had a fallback path avoiding it when the operator isn't available. The fallback effectively has undefined behaviour and it is targetting unknown compilers so it is probably not a good idea to leave it in. Instead, this patch just removes it. If someone finds a compiler that doesn't have __typeof__ but does work with the old implementation then maybe they could add it back in as a special case. This patch removes the initialisation anywhere where the sample pointer was being unitialised before using wl_container_of. The documentation for the macro has also been updated to specify that this is OK.

client: Include poll.h instead of sys/poll.h

2014-01-17T19:27:26Z

POSIX mandates the poll.h header as the standard location of poll(2).

add_shm_format: check wl_array_add return value before deref

2014-01-15T18:46:09Z

In wl_display_add_shm_format(), check the return value from wl_array_add() before dereferencing it and assigning it a value. Return the resulting pointer back to the caller. Signed-off-by: U. Artie Eoff

shm: assert sigbus_data is not NULL before member access

2014-01-15T18:46:08Z

Signed-off-by: U. Artie Eoff

Fix buffer overflow when serializing a closure object

2014-01-09T22:27:52Z

Here is the JIRA page of this issue https://bugs.tizen.org/jira/browse/TIVI-1889 Change-Id: I773a6d2d8f6fd02ff10c92450db1fa8a69544219 Signed-off-by: Chi Ding Closes: https://bugs.freedesktop.org/show_bug.cgi?id=65186

scanner: set errno=0 before strtol

2013-12-17T18:57:52Z

POSIX says to set errno=0 before calling strtol since the return value alne cannot tell a failure. on ubuntu armel I get: ../src/wayland-scanner client-header < ../../protocol/wayland.xml > wayland-client-protocol.h :1188: error: invalid integer (2) Signed-off-by: Adrian Negreanu

client: Handle EINTR in wl_display_dispatch_queue()

2013-12-10T00:19:33Z

Restart the poll() if we take a signal. This is easily triggered in an application that ends up blocking in eglSwapBuffers(), and causes EGL to fail to allocate a back buffer.

doc: Fix spelling of parameters

2013-12-09T23:50:01Z

Signed-off-by: Jonas Ådahl

doc: Remove incorrect docmentation

2013-12-09T23:43:04Z

The documentation was about wl_client_get_object(), not about wl_resource_get_client(). Signed-off-by: Jonas Ådahl

client: Make wl_proxy_set_queue() with NULL revert to default queue

2013-12-05T01:01:01Z

This will be useful in order to implement the EGL_WL_create_wayland_buffer_from_image extension. The buffers created within Mesa's Wayland platform are created using the the wl_drm object as a proxy factory which means they will be set to use Mesa's internal event queue. However, these buffers will be owned by the client application so they ideally need to use the default event loop. This function provides a way to set the proxy's event queue back to the default. krh: Edited from Neils original patch to just use wl_proxy_set_queue() with a NULL argument instead of introducing a new function.

Add -pthread to AM_CFLAGS to do the right thing when using threads

2013-11-23T20:24:43Z

https://bugs.freedesktop.org/show_bug.cgi?id=71633

connection: Error out if file descriptor was not received

2013-11-22T06:01:48Z

Otherwise the tail of fds_in buffer would just shift beyond the beginning. That confuses the actual request handler and results in a crash further on due to corrupted tail. Signed-off-by: Lubomir Rintel

wayland-server: Improve error messages for bad globals

2013-11-19T21:26:32Z

A bug in Weston's toytoolkit gave me an hour of debugging headaches. Improve the error messages that we send if a client requests an invalid global, either by name or by version.

client: Introduce functions to allocate and marshal proxies atomically

2013-11-16T04:49:36Z

The server requires clients to only allocate one ID ahead of the previously highest ID in order to keep the ID range tight. Failure to do so will make the server close the client connection. However, the way we allocate new IDs is racy. The generated code looks like: new_proxy = wl_proxy_create(...); wl_proxy_marshal(proxy, ... new_proxy, ...); If two threads do this at the same time, there's a chance that thread A will allocate a proxy, then get pre-empted by thread B which then allocates a proxy and then passes it to wl_proxy_marshal(). The ID for thread As proxy will be one higher that the currently highest ID, but the ID for thread Bs proxy will be two higher. But since thread B prempted thread A before it could send its new ID, B will send its new ID first, the server will see the ID from thread Bs proxy first, and will reject it. We fix this by introducing wl_proxy_marshal_constructor(). This function is identical to wl_proxy_marshal(), except that it will allocate a wl_proxy for NEW_ID arguments and send it, all under the display mutex. By introducing a new function, we maintain backwards compatibility with older code from the generator, and make sure that the new generated code has an explicit dependency on a new enough libwayland-client.so. A virtual Wayland merit badge goes to Kalle Vahlman, who tracked this down and analyzed the issue. Reported-by: Kalle Vahlman

wayland/src, branch 1.7

event-loop: Dispatch idle callbacks twice

client: unref or destroy proxy when releasing queue

client: release display queue in wl_display_disconnect()

scanner: Fix header generation for server protocols

cosmetic: Cleanup trailing whitespace

cosmetic: Move the deprecated functions back to the end of the file

doc: made functions taking wl_event_queue arg belong to wl_event_queue

doc: Remove wl_map from documentation

doc: Remove deprecated functions from documentation

doc: add missing \memberof to wl_display_get_protocol_error

server: Use existing id variable when inserting created object

client: update documentation about threading

client: update obsolete comments

scanner.c: Use WL_PRINTF instead of __attribute__((format(printf)))

doc: fixed grammar and a typo

doc: Removed extra indentation from wl_list code sample

doc: Removed \ref when it refers to the subject the text is attached to

doc: fixed a typo

v4 doc: fixed reference to non-existent function

doc: Added \code tags around sample code in doxygen comments

server: increase listen queue to 128

client: read_events should return -1 after an error

gitignore: adpat to scanner and protocol path changes

connection: abort if a listener function is NULL

Remove useless semicolon.

doc: Added API documentation for wl_display_destroy and wl_display_add_socket functions.

Don't document an absent parameter.

scanner, client: Added more error checks when strtol function is used

wayland-server: Abort if a read from a client gives 0 length

event-loop.c: Use correct OS abstraction function for dupfd()

connection: Fix sendmsg() on FreeBSD

cosmetic: convert some function returns from int to bool

connection: Leave fd open in wl_connection_destroy

doc: Mark up some code examples

scanner: Remove stray newline

scanner: Improve XML parse error reporting

shm: fix error in comment

client: cancel read in wl_display_read_events() when last_error is set

client: wake-up threads on all return paths from read_events

client: add display_wakeup_threads function

wayland-client: Initialize newly created wl_proxys to zero

client: check for error in wl_display_read_events

client: broadcast the right pthread_cond variable

client: drop unused event queue cond and list variables

client: remove unused variable

server: Don't expose wl_display as a global

client: add a public function to make a roundtrip on a custom queue

event-loop: make signalfd non-blocking

scanner: Make emit_structs more explicit

scanner: Use an enum to determine the type of thing we're writing out

server: fix conditions for fds in wl_socket_destroy

server: fix error handling when adding socket

server: move memset after check

server: Add a simple API to find a good default display

server: Save the display name in the wl_socket

server: Make get_socket_lock operate directly on the socket's lock_fd

server: Split out code to initialize the socket address for a display name

server: Create the socket FD after taking the lock

server: Clean up socket destruction

wayland-client: Fix indentation

doc: Fix link to wl_list_remove()

client: extend error handling

connection: remove unreached code

scanner: Downgrade non-increasing version error to warning

scanner: Generate macros for getting the 'since' version of an event

scanner: Also fail when an implicitly versioned message is out of order

doc: Added API documentation for wl_display_create function.

server: fix potential memleak and NULL deref

scanner: check wl_array_add result

Avoid printing to stderr

Use non-blocking timerfd to prevent blocking when updating timer event sources

connection: fix a format string typo in error message

connection: Don't write past the end of the connection buffer

shm: Disallow shrinking shm pools

scanner: Only output each forward declaration once

Add WL_PRINTF attribute and annotate wl_log_func_t

client: Delay EPIPE handling so we get a chance to handle error events

server: Kill some unnecessary logs

build: Move src/Makefile.am into toplevel Makefile.am

scanner.c: Use WL_PRINTF instead of attribute((format(printf)))