wayland/src/wayland-shm.c, branch 1.12

(multiple): Include stdint.h

2016-07-26T01:39:32Z

Some headers and source files have been using types such as uint32_t without explicitly including stdint.h. Explicitly include stdint.h where appropriate. Signed-off-by: Yong Bakos Reviewed-by: Eric Engestrom

wayland-shm: Include wayland-util.h

2016-06-07T13:07:01Z

wayland-shm.c uses WL_EXPORT and wl_array, which are defined in wayland-util.h. Include wayland-util.h explicitly, rather than transitively through wayland-server.h. Signed-off-by: Yong Bakos Reviewed-by: Sam Spilsbury

shm: Log a warning if a shm buffer address is requested when it may be invalid

2016-03-09T00:55:02Z

If wl_shm_buffer_get_data() is called on a shm pool that has an external reference and a pending resize, then the buffer may be outside the pool's current mapping. Log a warning if this happens. Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington

shm: Defer wl_shm_pool_resize if a pool has external references

2016-03-09T00:54:38Z

If a compositor is rendering in one thread while dispatching wayland events in another, a wl_shm_pool_resize() could change the memory mappings it's rendering from and cause a crash. Now we defer wl_shm_pool_resize() if the compositor has references on a pool, and perform the actual resize when it drops those references. Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington

shm: Split pool reference counting into external and internal references

2016-03-09T00:54:25Z

This is a preliminary step towards deferring shm resize operations until after the compositor has released all external references on a pool. Signed-off-by: Derek Foreman Reviewed-by: Bryce Harrington

server: Fix shm_create_pool size fail path fd leak

2016-03-09T00:37:20Z

If the client passed a size <= 0 to shm_create_pool, it would go to err_free, which wouldn't close the fd, and thus leave it opened. We can also move the size check before the struct wl_shm_pool malloc, so in case the client passes a wrong size, it won't do an unnecessary malloc and then free. Reviewed-by: Bryce Harrington Reviewed-by: Pekka Paalanen

cosmetic: add an space after if

2016-02-05T00:37:40Z

doc: Fix incorrect parameter name

2016-01-12T04:13:12Z

Signed-off-by: Jonas Ådahl Reviewed-by: Daniel Stone Reviewed-by: Marek Chalupa Reviewed-by: Derek Foreman

Use zalloc instead of malloc + memset

2016-01-12T04:13:12Z

Signed-off-by: Jonas Ådahl Reviewed-by: Daniel Stone Reviewed-by: Marek Chalupa Reviewed-by: Derek Foreman

shm: wl_shm_buffer_get_data() requires a valid pool.

2015-11-06T11:42:52Z

There's no situation where a shm buffer without a pool makes sense, so we enforce the pool's existence a little more rigidly. Acked-by: Pekka Paalanen Signed-off-by: Derek Foreman Reviewed-by: Giulio Camuffo

shm: Move deprecated function to the bottom of the file

2015-11-06T11:42:46Z

In wayland-server.c we group the deprecated functions and disable doxygen for them. Do that here too. Acked-by: Pekka Paalanen Signed-off-by: Derek Foreman Reviewed-by: Giulio Camuffo

shm: Deprecate wl_shm_buffer_create()

2015-11-06T11:42:33Z

From irc: it creates a wl_buffer object in a way that no client can ever access the storage. So, let's replace it with return NULL; and mark it with attribute deprecated in the header. Reviewed-by: Pekka Paalanen Signed-off-by: Derek Foreman Reviewed-by: Giulio Camuffo

shm: Add shm_buffer ref and shm_pool unref functions

2015-10-21T21:31:51Z

Sometimes the compositor wants to make sure a shm pool doesn't disappear out from under it. For example, in Enlightenment, rendering happens in a separate thread while the main thread can still dispatch events. If a client is destroyed during rendering, all its resources are cleaned up and its shm pools are unmapped. This causes the rendering thread to segfault. This patch adds a way for the compositor to increment the refcount of the shm pool so it can't disappear, and decrement it when it's finished. The ref/unref are asymmetrical (ref returns the pool) because it's possible the buffer itself will be gone when you need to unref the pool. Reviewed-by: Pekka Paalanen Signed-off-by: Derek Foreman

src: Update boilerplate from MIT X11 license to MIT Expat license

2015-06-12T22:31:24Z

Signed-off-by: Bryce Harrington Reviewed-by: Pekka Paalanen

cosmetic: convert some function returns from int to bool

2014-11-04T11:01:58Z

[Pekka Paalanen: change is_nullable_type() return value to bool.] Reviewed-by: Pekka Paalanen

shm: fix error in comment

2014-09-11T08:46:45Z

shm: Disallow shrinking shm pools

2014-04-07T23:01:25Z

Unused shm space will be automatically reclaimed if unused or can be explicitly returned by using fallocate FALLOC_FL_PUNCH_HOLE. https://bugs.freedesktop.org/show_bug.cgi?id=74632

shm: assert sigbus_data is not NULL before member access

2014-01-15T18:46:08Z

Signed-off-by: U. Artie Eoff

shm: Avoid file descriptor leak upon unsuccessful mmap

2013-11-16T00:21:45Z

It would be possible to make the compositor leak file descriptors by passing descriptors of open unmmapable files to it, such as /dev/null. Signed-off-by: Lubomir Rintel

Add documentation for wl_shm_buffer_begin/end_access

2013-11-15T22:46:48Z

It's not obvious that these functions are needed so it would be good to have some documentation for them.

server: Add API to protect access to an SHM buffer

2013-11-14T00:31:28Z

Linux will let you mmap a region of a file that is larger than the size of the file. If you then try to read from that region the process will get a SIGBUS signal. Currently the clients can use this to crash a compositor because it can create a pool and lie about the size of the file which will cause the compositor to try and read past the end of it. The compositor can't simply check the size of the file to verify that it is big enough because then there is a race condition where the client may truncate the file after the check is performed. This patch adds the following two public functions in the server API which can be used wrap access to an SHM buffer: void wl_shm_buffer_begin_access(struct wl_shm_buffer *buffer); void wl_shm_buffer_end_access(struct wl_shm_buffer *buffer); The first time wl_shm_buffer_begin_access is called a signal handler for SIGBUS will be installed. If the signal is caught then the buffer for the current pool is remapped to an anonymous private buffer at the same address which allows the compositor to continue without crashing. The end_access function will then post an error to the buffer resource. The current pool is stored as part of some thread-local storage so that multiple threads can safely independently access separate buffers. Eventually we may want to add some more API so that compositors can hook into the signal handler or replace it entirely if they also want to do some SIGBUS handling.

shm: Add API for renderers to register additional pixel formats

2013-08-06T23:48:02Z

Replace two remaining wl_display_add_gloavl() occurences

2013-07-09T23:18:10Z

wayland-server: Remove error event posting from wl_resource_create

2013-07-02T21:01:46Z

The wl_client_add/new_object() functions sends out an NO_MEMORY error if the allocation fails. This was convenient in a couple of places where that was all the error handling that was needed. Unfortunately that looks like out-of-memory isn't handled at the call site and set a bad precedent for not cleaning up properly or not handling at all. As we're introducing wl_resource_create() as a replacement for those two functions, let's remove the automatic error event posting and require the caller to do that if necessary. This commit also introduces a new helper, wl_client_post_no_memory() to make it possible to send NO_MEMORY events from bind where we don't have a wl_resource.

Add wl_resource_create() and a version field to wl_resource

2013-07-02T21:01:23Z

A new function, wl_resource_create(), lets the compositor create a wl_resource for a given version of the interface. Passing 0 for the object ID will allocate a new ID. The implementation, user data and destructor can be set with wl_resource_set_implementation(). These two functions deprecates wl_client_add/new_object and the main difference and motivation is the ability to provide a version number for the resource. This lets the compositor track which version of the interface a client has created and we'll use that to verify incoming requests. Signed-off-by: Jason Ekstrand

server: Make wl_object and wl_resource opaque structs

2013-07-02T19:52:47Z

With the work to add wl_resource accessors and port weston to use them, we're ready to make wl_resource and wl_object opaque structs. We keep wl_buffer in the header for EGL stacks to use, but don't expose it by default. In time we'll remove it completely, but for now it provides a transition paths for code that still uses wl_buffer. Reviewed-by: Jason Ekstrand

Change wl_shm_buffer to use a resource pointer

2013-06-21T23:18:08Z

This commit also has the effect of making wl_shm_buffer no longer a wl_buffer derivative. Signed-off-by: Jason Ekstrand

Change SHM wl_buffer functions to use the wl_shm_buffer structure

2013-06-21T23:18:06Z

This commit does not break ABI. It merely changes the types of some things and adds a wl_shm_buffer_get function. Signed-off-by: Jason Ekstrand

Add accessor functions for wl_resource and deprecate wl_client_add_resource

2013-06-05T04:59:08Z

This is the first step towards making wl_resource an opaque pointer type. Signed-off-by: Jason Ekstrand

Add wl_resource_init and use it in libwayland implementations of data sharing and SHM

2013-03-19T03:04:32Z

This commit adds a wl_resource_init function for initializing wl_resource structures similar to wl_client_add_object. From this commit forward, wl_resource structures should not be initialized manually, but should use wl_resource_init. In the event of a change to the wl_resource structure, this allows us to protect against regressions by filling in added fields with reasonable defaults. In this way, while changing wl_object or wl_resource still constitutes an ABI break, compositors following this rule will only need to be recompiled in order to properly link against the new version. Signed-off-by: Jason Ekstrand

Move un-namespaced container_of into private header

2012-10-20T03:06:53Z

Add wl_shm_buffer_create()

2012-08-16T14:49:48Z

wayland-shm: Commit the width/height getters that actually compile

2012-07-20T16:30:07Z

shm: Add shm_buffer getters for width and height

2012-07-20T16:04:42Z

wayland-shm: Add return before we hit the error clean-up path

2012-07-10T01:50:39Z

Regression in c94c0946db694ec29b5aebb94a8be0501bacfbc7

shm: Plug leak in shm_create_pool()

2012-07-09T21:59:45Z

shm: use mremap on pool resize

2012-05-23T14:03:53Z

shm: Zero busy count for allocated buffers

2012-05-22T19:50:26Z

This avoids a valgrind error like: ==31496== Conditional jump or move depends on uninitialised value(s) ==31496== at 0x407620: weston_buffer_post_release (compositor.c:928) ==31496== by 0x406AEB: weston_surface_attach (compositor.c:725) ==31496== by 0x409EB8: pointer_attach (compositor.c:2009) ==31496== by 0x34ECE05D63: ffi_call_unix64 (unix64.S:75) ==31496== by 0x34ECE05784: ffi_call (ffi64.c:486) ==31496== by 0x5674C4D: wl_closure_invoke (connection.c:770) ==31496== by 0x566ECCB: wl_client_connection_data (wayland-server.c:255) ==31496== by 0x56722F9: wl_event_source_fd_dispatch (event-loop.c:79) ==31496== by 0x5672C99: wl_event_loop_dispatch (event-loop.c:410) ==31496== by 0x56705FF: wl_display_run (wayland-server.c:1004) ==31496== by 0x40C775: main (compositor.c:2937) ==31496== Uninitialised value was created by a heap allocation ==31496== at 0x4A074CD: malloc (vg_replace_malloc.c:236) ==31496== by 0x5670EA7: shm_pool_create_buffer (wayland-shm.c:113) ==31496== by 0x34ECE05D63: ffi_call_unix64 (unix64.S:75) ==31496== by 0x34ECE05784: ffi_call (ffi64.c:486) ==31496== by 0x5674C4D: wl_closure_invoke (connection.c:770) ==31496== by 0x566ECCB: wl_client_connection_data (wayland-server.c:255) ==31496== by 0x56722F9: wl_event_source_fd_dispatch (event-loop.c:79) ==31496== by 0x5672C99: wl_event_loop_dispatch (event-loop.c:410) ==31496== by 0x56705FF: wl_display_run (wayland-server.c:1004) ==31496== by 0x40C775: main (compositor.c:2937)

shm: Add request for resizing pools

2012-05-22T19:20:12Z

Switch protocol to using serial numbers for ordering events and requests

2012-04-12T02:27:26Z

The wayland protocol, as X, uses timestamps to match up certain requests with input events. The problem is that sometimes we need to send out an event that doesn't have a corresponding timestamped input event. For example, the pointer focus surface goes away and new surface needs to receive a pointer enter event. These events are normally timestamped with the evdev event timestamp, but in this case, we don't have a evdev timestamp. So we have to go to gettimeofday (or clock_gettime()) and then we don't know if it's coming from the same time source etc. However for all these cases we don't need a real time timestamp, we just need a serial number that encodes the order of events inside the server. So we introduce a serial number mechanism that we can use to order events. We still need real-time timestamps for actual input device events (motion, buttons, keys, touch), to be able to reason about double-click speed and movement speed so events that correspond to user input carry both a serial number and a timestamp. The serial number also give us a mechanism to key together events that are "logically the same" such as a unicode event and a keycode event, or a motion event and a relative event from a raw device.

shm: Allocate shm buffers through new wl_shm_pool interface

2012-04-03T16:34:22Z

There's a big cost to setting up and tearing down a mmap and faulting in the pages to back it. For cases where we're continuously reallocating shm wl_buffers (resizing a surface, typically) it is a big performance improvement to be able to reuse a mmap area. This change makes the shm buffer allocation a two step process: first allocate a wl_shm_pool, then allocate a buffer from the pool. The wl_shm_pool encapsulate the shared memory pool, and lets clients allocate wl_buffers backed by chunks of that memory. Buffers are allocated at an offset into the pool, so it's possible to create multiple buffers from one pool, for example for icons or cursor images.

shm: Fix stride signedness in protocol

2012-03-30T14:24:29Z

Make stride argument of wl_shm.create_buffer a signed integer.

shm: fix cosmetic gcc warnings

2012-03-30T14:09:38Z

Fix warning: 'static' is not at beginning of declaration Signed-off-by: Pekka Paalanen

Remove wl_buffer.damage and simplify shm implementation

2012-03-26T20:33:24Z

server: use the event sending wrappers

2012-03-02T16:06:19Z

This exposes some type mismatches that are fixed in the next commit. Signed-off-by: Pekka Paalanen

shm: Drop non-premul format, use less ambiguous ARGB8888 naming convention

2012-01-11T19:19:54Z

This also matches the new wl_drm format names.

server: Make error posting functions take a resource instead of a client

2011-09-01T13:53:33Z

Remove the wl_visual interface

2011-08-31T22:34:21Z

The visual interface was meant to be a generic mechanism for specifying the content of a buffer. It goes back to before we had the buffer factory interfaces (like wl_drm and wl_shm) and we wanted to keep it open-ended enough that yuv, png or even svg buffer or so would be possible. Now that we have the buffer abstraction, we can add different buffer types by introducing new interfaces that create buffers. It only makes sense to leave it to those interfaces to specify the contents of the buffers. For wl_shm, this means that we now just specify the pixel format using an enum. For EGL buffers, the exact pixel formats are controlled by the implementation (part of wl_drm and similar), and from the client point of view, everything is controlled using EGLConfigs.

shm: Compare resource interface when validating visual

2011-08-29T19:01:26Z

server: Pass struct wl_resource for object references

2011-08-27T16:06:11Z

Always allocate a new wl_resource when binding an object

2011-08-27T16:06:11Z

Previously we would bind some resources into multiple client hash tables.

server: Assign global id as part of wl_display_add_global()

2011-08-27T16:06:11Z

server: Make everything in the object hash a wl_resource

2011-08-27T16:06:10Z

Rename source subdir from wayland to src

2011-08-12T20:25:14Z