wayland/src/event-loop.c, branch master

event-loop: Track timer event sources in userspace

2020-01-21T11:31:35Z

libwayland now uses only one file descriptor to keep track of all the timer event sources associated with an event loop. An array-based binary heap is used to determine which event source has the earliest deadline. (Previously, each timer event source had its own timerfd, making it easy for the a process using many timer event sources to run out of file descriptors.) Signed-off-by: Manuel Stoeckl

Use wl_container_of internally

2019-06-05T09:58:14Z

Rather than have two versions of the macro with slightly different interfaces, just use wl_container_of internally. This also removes use of statement expressions, a GNU C extension. Signed-off-by: Michael Forney

log: remove "%m" from format strings by using strerror(errno)

2019-05-02T20:14:53Z

The printf() format specifier "%m" is a glibc extension to print the string returned by strerror(errno). While supported by other libraries (e.g. uClibc and musl), it is not widely portable. In Wayland code the format string is often passed to a logging function that calls other syscalls before the conversion of "%m" takes place. If one of such syscall modifies the value in errno, the conversion of "%m" will incorrectly report the error string corresponding to the new value of errno. Remove all the occurrences of the specifier "%m" in Wayland code by using directly the string returned by strerror(errno). Signed-off-by: Antonio Borneo

eventloop: clarify post_dispatch_check()

2017-12-04T19:45:38Z

This *technically* changes the semantics of the return value of the source callbacks. Previously you could return a negative number from a source callback and it would prevent *other* source callbacks from triggering a subsequent recheck. Doing that seems like such a bad idea it's not worth supporting. v2: Log this case if it is hit, so we don't silently change behaviour. Signed-off-by: Christopher James Halse Rogers Reviewed-by: Daniel Stone

server: document wl_event_loop and wl_event_source

2017-08-25T07:35:05Z

This documents all the public API related to wl_event_loop and wl_event_source objects. Signed-off-by: Pekka Paalanen Reviewed-by: Yong Bakos [Pekka: fixed typos pointed by Yong] [Pekka: fixed typos pointed by Christopher] Reviewed-By: Christopher James Halse Rogers

(multiple): Include stdint.h

2016-07-26T01:39:32Z

Some headers and source files have been using types such as uint32_t without explicitly including stdint.h. Explicitly include stdint.h where appropriate. Signed-off-by: Yong Bakos Reviewed-by: Eric Engestrom

server-core, event-loop: Fix parameter alignment.

2016-06-07T13:33:28Z

Signed-off-by: Yong Bakos Reviewed-by: Pekka Paalanen

event-loop: Include wayland-util.h

2016-06-07T13:07:08Z

event-loop.c uses WL_EXPORT and wl_list, which are defined in wayland-util.h. Include wayland-util.h explicitly, rather than transitively through wayland-server-core.h. Signed-off-by: Yong Bakos Reviewed-by: Sam Spilsbury

event-loop: Make transitive include explicit

2016-06-02T01:42:36Z

The explicit inclusion of wayland-server.h hides the real dependency, which is wayland-server-core.h. Signed-off-by: Yong Bakos Reviewed-by: Jonas Ådahl

event-loop: remove extra header

2015-11-16T19:42:01Z

we don't use assert() anywhere in this file, so remove #include Signed-off-by: Marek Chalupa Reviewed-by: Bryce Harrington

cosmetic: gratuitous whitespace changes in event-loop.c

2015-06-23T07:27:23Z

Signed-off-by: Derek Foreman Reviewed-by: Jon A. Cruz Reviewed-by: Pekka Paalanen

src: Update boilerplate from MIT X11 license to MIT Expat license

2015-06-12T22:31:24Z

Signed-off-by: Bryce Harrington Reviewed-by: Pekka Paalanen

event-loop: Dispatch idle callbacks twice

2015-01-29T02:12:31Z

To fix a shutdown crash in weston's x11 compositor I want to move the weston X window close to an idle handler. Since idle handlers are processed at the start of an event loop, the handler that deals with window close will run at the start of the next input_loop dispatch, after which the dispatcher blocks on epoll forever (since all input events that will ever occur have been consumed). Dispatching idle callbacks both at the start and end of event-loop processing will prevent this permanent blocking. Note that just moving the callback dispatch could theoretically result in an idle callback being delayed indefinitely while waiting for epoll_wait() to complete. Callbacks are removed from the list when they're run, so the second dispatch won't result in any extra calls. Signed-off-by: Derek Foreman Reviewed-by: Giulio Camuffo Reviewed-by: Bryce Harrington

event-loop.c: Use correct OS abstraction function for dupfd()

2014-11-05T12:17:25Z

Signed-off-by: Philip Withnall Signed-off-by: Karsten Otto Reviewed-by: David Fort Reviewed-by: Marek Chalupa Reviewed-by: Pekka Paalanen

event-loop: make signalfd non-blocking

2014-08-18T10:03:00Z

When we add more that one source to a signal, then wayland will block in wl_event_loop_dispatch. This is due to the attampt to read from signal's fd each time the source is dispatched. wl_event_loop_add_signal(loop, SIGINT, ...); wl_event_loop_add_signal(loop, SIGINT, ...); /* raise signal .. */ /* we got two fd's ready, both for the one SIGINT */ epoll_wait(...) = 2 [ for (i == 0) ] source1->dispatch() --> read(fd1); [ for (i == 1) ] source2->dispatch() --> read(fd2); /* blocking! */ Reading from fd2 will block, because we got only one signal, and it was read from fd1. Signed-off-by: Marek Chalupa Reviewed-by: Pekka Paalanen

Avoid printing to stderr

2014-04-30T19:18:52Z

Use wl_log in the last few places where we print to stderr. Remove logging in a couple of places where we properly return an error code. https://bugs.freedesktop.org/show_bug.cgi?id=73339

Use non-blocking timerfd to prevent blocking when updating timer event sources

2014-04-25T21:38:22Z

This implements a simple fix for the blocking problem that occurs when updating a timer event source after the timer expires, but before its callback is dispatched. This can happen when another event happens during the same epoll wakeup as the timer event, and causes the read() call in wl_event_source_timer_dispatch() to block for the updated duration of the timer. We never want this read() call to block, so I believe it makes sense for the timerfd to be non-blocking, and we simply ignore the case where the read fails with EAGAIN. We still report all other errors as before, and still ignore the actual value read from the socket. With this change, the event_loop_timer_updates unit test case I submitted previously now passes, and weston appears to work as before.

server: Make wl_object and wl_resource opaque structs

2013-07-02T19:52:47Z

With the work to add wl_resource accessors and port weston to use them, we're ready to make wl_resource and wl_object opaque structs. We keep wl_buffer in the header for EGL stacks to use, but don't expose it by default. In time we'll remove it completely, but for now it provides a transition paths for code that still uses wl_buffer. Reviewed-by: Jason Ekstrand

event-loop: fix returning the destroy-signal listener

2013-01-24T21:14:33Z

We need to actually return the destroy-listener, otherwise the return value is undefined. Signed-off-by: David Herrmann

Add a destroy signal to the wl_event_loop object

2013-01-15T19:05:27Z

Move ARRAY_LENGTH out of public headers

2012-10-19T21:08:38Z

Exporting unprefixed symbols is a pretty bad idea so don't do that. Instea of redefining it WL_ARRAY_LENGTH, we just move the define to our private header. The scanner generates code that uses ARRAY_LENGTH, but we can just make it count the number elements and emit an integer constant instead.

Change filedescriptor API to be thread safe

2012-10-11T00:59:00Z

The update callback for the file descriptors was always a bit awkward and un-intuitive. The idea was that whenever the protocol code needed to write data to the fd it would call the 'update' function. This function would adjust the mainloop so that it polls for POLLOUT on the fd so we can eventually flush the data to the socket. The problem is that in multi-threaded applications, any thread can issue a request, which writes data to the output buffer and thus triggers the update callback. Thus, we'll be calling out with the display mutex held and may call from any thread. The solution is to eliminate the udpate callback and just require that the application or server flushes all connection buffers before blocking. This turns out to be a simpler API, although we now require clients to deal with EAGAIN and non-blocking writes. It also saves a few syscalls, since the socket will be writable most of the time and most writes will complete, so we avoid changing epoll to poll for POLLOUT, then write and then change it back for each write.

event-loop: export wl_event_loop_dispatch_idle()

2012-09-12T16:28:54Z

When integrating the wayland event-loop into another event-loop, we currently have no chance of checking whether there are pending idle sources that have to be called. This patch exports the "dispatch_idle_sources()" call so other event loops can call this before going to sleep. This is what wl_event_loop_dispatch() currently does so we simply allow external event-loops to do the same now. To avoid breaking existing applications, we keep the call to dispatch_idle_sources() in wl_event_loop_dispatch() for now. However, if we want we can remove this later and require every application to call this manually. This needs to be discussed, but the overhead is negligible so we will probably leave it as it is. This finally allows to fully integrate the wayland-server API into existing event-loops without any nasty workarounds. Signed-off-by: David Herrmann

event-loop: remove dead code

2012-09-11T01:28:34Z

There is really no need to increment "n" if we never read the value. The do-while() loop overwrites the value before it is read the first time. Signed-off-by: David Herrmann

event-loop: Delete fd from epoll when removing event source

2012-05-08T14:42:42Z

Closing an fd will remove it from the epoll set only if it hasn't been dup'ed. In other words, the fd is only removed from epoll when all file descriptors referring to the open file has been close. We now dup fd for fd sources, so we need to use EPOLL_CTL_DEL directly now.

event-loop: Consolidate code for setting up new sources

2012-05-08T13:30:49Z

event-loop: fix conditional checking

2012-05-08T13:08:57Z

Introduced in: commit 80f4f0d5127ebc8d5e35969a29691cf61a79997d Author: Jonas Ådahl Date: Wed Mar 21 10:31:24 2012 +0100 Signed-off-by: Tiago Vignatti

os: wrap epoll_create

2012-04-25T06:37:42Z

Some system C libraries do not have epoll_create1() nor EPOLL_CLOEXEC, provide a fallback. Add tests for the wrapper. Signed-off-by: Pekka Paalanen

event-loop: Use two-step destruction of event loop sources.

2012-03-21T14:30:19Z

Instead of directly freeing an event source upon removal put it in a queue later handled by the event loop; either after a dispatch or upon event loop destruction. This is necessary to avoid already queued up event sources to be freed during some other dispatch callback, causing segmentation faults when the event loop later tries to handle an event from the freed source. Signed-off-by: Jonas Ådahl

event-loop: always do the post-dispatch check

2012-03-20T19:15:19Z

The post-dispatch check on wl_event_loop_dispatch() was not being run if epoll_wait returned 0 events, making the check unreliable.

Fix WL_EVENT_WRITEABLE typo

2011-12-29T03:51:34Z

event-loop: Fix idle handler dispatch corner case

2011-10-29T18:27:33Z

When the last idle handler queues another idle handler, we fail to dispatch that last handler. The wl_list_for_each_safe loop looks up the next pointer before running the handler, and at that point it points to the head of the list and the loop terminates. Instead, just loop until the list is empty.

event-loop: Quiet a few warnings

2011-08-12T20:25:18Z

There's no good error recovery possible in these cases though.

Rename source subdir from wayland to src

2011-08-12T20:25:14Z