wayland/cursor, branch main

build: remove redundant Meson version conditionals

2026-07-20T05:24:49Z

Fixes warning with Meson 1.12: src/meson.build:221: WARNING: Conditional on version '>= 0.54.0' always evaluates to true Signed-off-by: Benjamin Gilbert

cursor: fix discards 'const' qualifier

2026-03-03T21:36:37Z

Fixes: ../cursor/xcursor.c: In function 'xcursor_next_path': ../cursor/xcursor.c:610:23: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 610 | char *colon = strchr(path, ':'); | ^~~~~~ Signed-off-by: Rudi Heitbaum

cursor: Free theme when size check fails to avoid memory leak

2025-08-03T11:36:34Z

Signed-off-by: YaoBing Xiao

cursor: Properly check realloc for errors

2025-06-08T16:16:09Z

Do not override realloc's input pointer before checking for errors, otherwise it's not possible to keep old value, as intended. Signed-off-by: Tobias Stoeckmann

cursor: Ignore invalid cursor files

2025-06-08T16:16:09Z

The header offset must not be smaller than file header length. Ignore such invalid files. Signed-off-by: Tobias Stoeckmann

cursor: Gracefully handle huge cursor files

2025-06-08T16:16:09Z

If cursor files require more than INT_MAX bytes, it is possible to trigger out of boundary writes. Since these sizes are most likely not desired anyway, gracefully handle these situations like out of memory errors. Signed-off-by: Tobias Stoeckmann

cursor: Gracefully handle out of memory condition

2025-06-08T16:16:09Z

If the full path could not be constructed, avoid calling opendir(NULL) which, depending on library, might trigger undefined behavior. Signed-off-by: Tobias Stoeckmann

cursor: Fix undefined behavior with huge names

2025-06-08T16:16:09Z

If an index.theme contains a theme name which gets close to INT_MAX, then creation of full path can lead to a signed integer overflow, which is undefined behavior. Fix this by turning one of the values to size_t. Easy solution for a probably never occurring issue. Signed-off-by: Tobias Stoeckmann

Fix typos

2025-05-20T20:49:32Z

Typos found with codespell and during code audit. Signed-off-by: Tobias Stoeckmann

cursor: add check to ensure wl_shm_create_pool succeeded

2024-10-18T08:49:45Z

Signed-off-by: YaoBing Xiao

src: Finish assert() clean-up

2024-08-09T20:38:52Z

From cleanup commit 0cecde304: assert()s can be compiled away by #defining NDEBUG. Some build systems do this. Using wl_abort gives a human readable error message and it isn't compiled away. That commit missed one final assert, presumably due to missing it with grep because of a coding style issue. Fix that up, and remove inclusion of as appropriate. Signed-off-by: Derek Foreman

xcursor: catch theme inheritance loops

2024-04-24T10:28:38Z

As of currently, when an xcursor theme depends on itself or another theme that will eventually depend on it, `xcursor_load_theme` will recurse infinitely while processing the inherits. This change introduces a stack-allocated linked list of visited nodes by name, and skips any already visited nodes in the inherit list. Side effects: * Since the linked list is stack-allocated, there is a potential for an overflow if there is a very long list of dependencies. If this turns out to be a legitimate concern, the linked list is trivial to convert to being heap-allocated. * There is an existing linked list (technically doubly linked list) implementation in the wayland codebase. As of currently, the xcursor codebase does not refer to it. Consequently, this change writes a minimal single linked list implementation to utilize directly. This changeset fixes #317. Signed-off-by: Chloé Vulquin

cursor: memfd_create: try MFD_NOEXEC_SEAL

2024-04-21T17:17:46Z

Effective from Linux 6.3 onward, this creates the memfd without execute permissions and prevents that setting from ever being changed. A run-time fallback is made to not using MFD_NOEXEC_SEAL when a libwayland-cursor compiled on Linux >= 6.3 is run on Linux < 6.3. This is a defense-in-depth security measure and silences a respective kernel warning; see: https://lwn.net/Articles/918106/ This implementation is adopted from dnkl's `foot` terminal emulator. Signed-off-by: 6t8k <6t8k@noreply.codeberg.org>

cursor: add aliases for cursor name spec

2024-01-19T14:08:16Z

The cursor name spec [1] describes how cursors should be named, and is widely used. Add aliases so that users can pass these names to libwayland-cursor without having to add fallbacks for X11 cursor names. [1]: https://www.freedesktop.org/wiki/Specifications/cursor-spec/ Signed-off-by: Simon Ser

cursor: check return value of snprintf()

2023-08-02T14:47:07Z

Fixes a new warning in GCC 7: FAILED: cursor/libwayland-cursor.so.0.22.90.p/xcursor.c.o cc -Icursor/libwayland-cursor.so.0.22.90.p -Icursor -I../cursor -I. -I.. -Isrc -I../src -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c99 -O3 -D_POSIX_C_SOURCE=200809L -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -fvisibility=hidden -fPIC '-DICONDIR="/usr/share/X11/icons"' -MD -MQ cursor/libwayland-cursor.so.0.22.90.p/xcursor.c.o -MF cursor/libwayland-cursor.so.0.22.90.p/xcursor.c.o.d -o cursor/libwayland-cursor.so.0.22.90.p/xcursor.c.o -c ../cursor/xcursor.c ../cursor/xcursor.c: In function 'xcursor_load_theme': ../cursor/xcursor.c:596:39: error: '%s' directive output between 7 and 7 bytes may cause result to exceed 'INT_MAX' [-Werror=format-truncation=] 596 | snprintf(full, full_size, "%s/%s/%s", dir, subdir, file); | ^~ ...... 764 | full = xcursor_build_fullname(dir, "cursors", ""); | ~~~~~~~~~ ../cursor/xcursor.c:596:41: error: '/' directive output between 1 and 1 bytes may cause result to exceed 'INT_MAX' [-Werror=format-truncation=] 596 | snprintf(full, full_size, "%s/%s/%s", dir, subdir, file); | ^ cc1: all warnings being treated as errors Signed-off-by: Simon Ser

cursor: make param names match with documentation

2022-09-13T18:01:57Z

There was a mismatch here. Use a good-looking function param name because that's what will show up in docs. Use an abbreviation inside the function. Fixes the following warnings: cursor/wayland-cursor.c:504: warning: argument 'cursor' of command @param is not found in the argument list of wl_cursor_frame(struct wl_cursor *_cursor, uint32_t time) cursor/wayland-cursor.c:504: warning: The following parameter of wl_cursor_frame(struct wl_cursor *_cursor, uint32_t time) is not documented: parameter '_cursor' cursor/wayland-cursor.c:452: warning: argument 'cursor' of command @param is not found in the argument list of wl_cursor_frame_and_duration(struct wl_cursor *_cursor, uint32_t time, uint32_t *duration) cursor/wayland-cursor.c:452: warning: The following parameter of wl_cursor_frame_and_duration(struct wl_cursor *_cursor, uint32_t time, uint32_t *duration) is not documented: parameter '_cursor' cursor/wayland-cursor.c:147: warning: argument 'image' of command @param is not found in the argument list of wl_cursor_image_get_buffer(struct wl_cursor_image *_img) cursor/wayland-cursor.c:147: warning: The following parameter of wl_cursor_image_get_buffer(struct wl_cursor_image *_img) is not documented: parameter '_img' cursor/wayland-cursor.c:504: warning: argument 'cursor' of command @param is not found in the argument list of wl_cursor_frame(struct wl_cursor *_cursor, uint32_t time) cursor/wayland-cursor.c:504: warning: The following parameter of wl_cursor_frame(struct wl_cursor *_cursor, uint32_t time) is not documented: parameter '_cursor' cursor/wayland-cursor.c:452: warning: argument 'cursor' of command @param is not found in the argument list of wl_cursor_frame_and_duration(struct wl_cursor *_cursor, uint32_t time, uint32_t *duration) cursor/wayland-cursor.c:452: warning: The following parameter of wl_cursor_frame_and_duration(struct wl_cursor *_cursor, uint32_t time, uint32_t *duration) is not documented: parameter '_cursor' cursor/wayland-cursor.c:147: warning: argument 'image' of command @param is not found in the argument list of wl_cursor_image_get_buffer(struct wl_cursor_image *_img) cursor/wayland-cursor.c:147: warning: The following parameter of wl_cursor_image_get_buffer(struct wl_cursor_image *_img) is not documented: parameter '_img' Signed-off-by: Simon Ser

cursor/os-compatibility: handle EINTR gracefully

2022-06-09T19:18:47Z

If os_resize_anonymous_file() called from os_create_anonymous_file() fails with EINTR (Interrupted system call), then the buffer allocation fails. To avoid that, retry posix_fallocate() on EINTR. However, in the presence of an alarm, the interrupt may trigger repeatedly and prevent a large posix_fallocate() to ever complete successfully, so we need to first block SIGALRM to prevent this. Signed-off-by: Olivier Fourdan

Check that XDG base directories paths are absolute

2022-06-09T18:34:17Z

The [spec][1] reads: > All paths set in these environment variables must be absolute. If an > implementation encounters a relative path in any of these variables it should > consider the path invalid and ignore it. and > If $XDG_DATA_HOME is either not set or empty, a default equal to > $HOME/.local/share should be used. Testing that the path is absolute also entails that is is non-empty. [1]: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html Signed-off-by: Antonin Décimo

cursor/os-compatibility: fix trailing space

2022-06-04T20:58:50Z

Signed-off-by: Simon Ser

cursor/os-compatibility: remove strcpy/strcat usage

2022-06-04T20:58:47Z

These functions don't perform bounds checking, so they are easy to misuse and complicate audits. Signed-off-by: Simon Ser

cursor: move xcursor_theme_inherits declarations at the top

2022-05-27T20:41:12Z

Per code style, declarations need to be at the start of the block. And make l const while at it. Signed-off-by: Simon Ser

cursor: drop xcursor_add_path_elt

2022-05-27T20:41:12Z

Just use snprintf instead. It doesn't really matter if we have some duplicate slashes in filenames. Signed-off-by: Simon Ser

cursor: drop unused XCursor comment declarations

2022-05-27T20:41:12Z

Signed-off-by: Simon Ser

cursor: fix indentation of xcursor_load_theme declaration

2022-05-27T20:41:12Z

Signed-off-by: Simon Ser

cursor: simplify xcursor_library_path

2022-05-27T20:41:11Z

- Use early returns - De-duplicate XDG_DATA_HOME code-paths - Don't crash on allocation failure - Use size_t when appropriate - Fix indentation Signed-off-by: Simon Ser

cursor: remove unnecessary ifs in xcursor_load_theme

2022-05-27T20:41:11Z

load_all_cursors_from_dir and xcursor_theme_inherits already have the NULL checks we want. Signed-off-by: Simon Ser

cursor: drop xcursor_images_set_name

2022-05-27T20:41:11Z

We don't ever need to set the name multiple times for a single struct xcursor_images, so we can just set the field directly. Also replace the hand-rolled logic with strdup. Signed-off-by: Simon Ser

cursor: use getline instead of fgets

2022-05-27T20:41:11Z

This avoids storing 8KiB on the stack, and removes the line length limit. Signed-off-by: Simon Ser

cursor: remove unnecessary parentheses in load_all_cursors_from_dir

2022-05-27T20:41:10Z

Signed-off-by: Simon Ser

cursor: remove xcursor_file_load_images wrapper

2022-05-27T14:01:42Z

It's just calling xcursor_xc_file_load_images. Signed-off-by: Simon Ser

cursor: rename local variables to snake case

2022-05-23T08:59:05Z

Signed-off-by: Simon Ser

cursor: drop xcursor_file abstraction

2022-05-23T08:59:05Z

Just use FILE * directly instead. Signed-off-by: Simon Ser

cursor: refactor xcursor_theme_inherits

2022-05-23T08:59:05Z

Use early returns and breaks to avoid dealing with very long indentation lines. Signed-off-by: Simon Ser

cursor: convert macros to functions

2022-05-23T08:59:05Z

Improves readability since there's no need for so many parentheses anymore, adds type safety. The compiler will inline the function automatically as necessary. Signed-off-by: Simon Ser

cursor: rename functions to snake case

2022-05-23T08:59:05Z

Signed-off-by: Simon Ser

cursor: fix whitespace in function args definitions

2022-05-23T08:59:05Z

Signed-off-by: Simon Ser

cursor: remove struct typedefs, rename to snake case

2022-05-23T08:59:05Z

Signed-off-by: Simon Ser

cursor: fix spacing around conditions and loops

2022-05-23T08:59:05Z

Signed-off-by: Simon Ser

cursor: fix indentation

2022-05-23T08:59:05Z

Use tabs. Signed-off-by: Simon Ser

cursor: remove unnecessary if before free

2022-05-23T08:59:05Z

free(NULL) is valid and is a no-op. Signed-off-by: Simon Ser

cursor: fix variable declaration style

2022-05-23T08:59:05Z

Use a single space between type and variable name. Signed-off-by: Simon Ser

cursor: fix struct declaration style

2022-05-23T08:59:05Z

Use tabs for indentation, don't use tabs to align field names. Signed-off-by: Simon Ser

cursor: fix define style

2022-05-23T08:59:05Z

Don't use tabs, don't align. Signed-off-by: Simon Ser

cursor: drop whitespace before parens in function calls

2022-05-23T08:59:05Z

This is in line with the rest of the Wayland code style. Signed-off-by: Simon Ser

cursor: drop XCURSOR_LIB_* defines

2022-05-23T08:59:05Z

These are unused. Signed-off-by: Simon Ser

cursor: drop XcursorTrue and XcursorFalse

2022-05-23T08:59:05Z

Just use instead. Signed-off-by: Simon Ser

cursor: remove private Xcursor int typedefs

2022-05-23T08:59:05Z

Just use the types directly instead. Signed-off-by: Simon Ser

cursor: use MAP_FAILED instead of hardcoded constant

2022-05-06T19:57:24Z

Signed-off-by: Simon Ser

cursor: Remove unused XcursorLibraryLoadImages() function

2022-02-05T14:33:32Z

XcursorLibraryLoadImages() function is unused and not exported according to objdump, so its removal should be an ABI compatible change. Signed-off-by: Vlad Zahorodnii

build: don't rely on implicit GNU extensions

2022-01-10T14:08:46Z

Currently libwayland assumes GNU extensions will be available, but doesn't define the C standard to use. Instead, let's unconditionally enable POSIX extensions, and enable GNU extensions on a case-by-case basis as needed. Signed-off-by: Simon Ser

meson: override dependencies to ease use as subproject

2021-12-07T23:27:58Z

Make it easier to use Wayland as a Meson subproject by overriding dependencies we define. This allows to easily build Wayland as a subproject like so: subproject('wayland', required: false, default_options: ['documentation=false']) After this statement, the wayland-* dependencies will use the subproject instead of the system if available. Signed-off-by: Simon Ser

build: Include the Wayland minor version in libraries' ABI versions

2021-10-28T12:46:06Z

The ABI of a shared library on Linux is given by a major version, which is part of the SONAME and is incremented (rarely) on incompatible changes, and a minor version, which is part of the basename of the regular file to which the SONAME provides a symlink. Until now, the ABI minor version was hard-coded, which means we can't tell which of a pair of Wayland libraries is newer (and therefore likely to have more symbols and/or fewer bugs). libwayland-egl already had ABI major version 1, so we can use the "marketing" version number as the ABI major.minor version number directly, so Wayland 1.19.90 would produce libwayland-egl.so.1 -> libwayland-egl.so.1.19.90. libwayland-cursor and libwayland-server have ABI major version 0, and OS distributions don't like it when there's a SONAME bump for no good reason, so use their existing ABI major version together with the "marketing" minor version: libwayland-cursor.so.0 -> libwayland-cursor.so.0.19.90. If the Wayland major version number is incremented to 2, we'll have to rethink this, so add some error() to break the build if/when that happens. Assuming that Wayland 2.0 would involve breaking changes, the best way would probably to bump all the SONAMEs to libwayland-foo.so.2. Resolves: https://gitlab.freedesktop.org/wayland/wayland/-/issues/175 Signed-off-by: Simon McVittie

cursor: remove unused wl_cursor_theme.name

2021-08-06T09:26:03Z

Let's just delete this field since it's not used anywhere and not exposed in our public API. Signed-off-by: Simon Ser

cursor: rename load_default_theme to load_fallback_theme

2021-08-05T15:24:02Z

The theme getting loaded by this function is not to be confused with the theme named "default" located on the filesystem. Instead, it's a minimal theme directly bundled into libwayland-cursor. Make this clearer by naming this theme "fallback". Signed-off-by: Simon Ser

cursor: Try to fall back to a default xcursor theme first

2021-08-05T15:09:40Z

The use case is systems where for some reason the current xcursor theme cannot be accessed (an application packaged as a strictly confined snap, for example). Before falling back to wayland's default cursor theme, it is worth trying the xcursor theme called "default", which hopefully looks better than the former. Fixes: https://gitlab.gnome.org/Community/Ubuntu/gnome-sdk/-/issues/6 Signed-off-by: Olivier Tilloy

cursor: fix crash with weird input files

2021-06-02T13:46:33Z

If a cursor file contains multiple images for the same size, this typically indicates an animation. The compositor weston uses wl_cursor_frame_and_duration to figure out at which time a specific image should be shown. The total delay is the sum of all image delays. But if all images have a delay of 0, the total delay is 0 as well. The code does not check for this special condition and triggers a floating point exception by eventually performing a modulo operation with 0. This, of course, could also happen if the sum of all image delays triggers an unsigned int overflow. But since a comment in the code already indicates that it does not try to "fix" handling of weird files, I would argue that it's "okay" if that happens. At least the program won't crash. Proof of Concept: install -D ~/.icons/poc/cursors base64 -d > ~/.icons/poc/cursors/left_ptr << EOF WGN1chAAAAAAAAEAAgAAAAIA/f8BAAAAKAAAAAIA/f8BAAAAKAAAACQAAAACAP3/AQAAAAEAAAAB AAAAAQAAAAEAAAABAAAAAAAAAAAAAAA= EOF cat > /tmp/weston.ini << EOF [shell] cursor-theme=poc EOF weston -c /tmp/weston.ini Signed-off-by: Tobias Stoeckmann

cursor: fix CVE-2013-2003

2021-05-02T19:35:23Z

The libXcursor fix for CVE-2013-2003 has never been imported into wayland, leaving it vulnerable to it. Changing the argument type to an unsigned type is an effective merge of Ilja Van Sprundel's commit in libXcursor. Signed-off-by: Tobias Stoeckmann

cursor: add one more directory to XCURSORPATH

2021-04-27T11:16:17Z

The user may install cursor themes manually, and the desktop environment may provide a special directory for storing them. For instance, GTK puts those themes into ~/.local/share/icons, and many Linux distributions suggest using that directory for user-specific themes. However, users of libwayland-cursor cannot load these themes using the API provided by the library because the latter does not look into that directory. This patch adds ~/.local/share/icons to the search path, so user-specific themes can be loaded through the API provided by libwayland-cursor. Signed-off-by: Alexander Dunaev Reviewed-by: Emmanuel Gil Peyrot Reviewed-by: Simon Ser

build: drop autotools

2021-03-05T09:15:04Z

Meson now replaces autotools. Signed-off-by: Simon Ser

cursor: fix typo "insufficent"

2020-12-17T21:03:14Z

cursor/convert_font.c: malloc cannot guarantee that the memory allocated is always successful

2020-10-29T13:00:20Z

Fix undefined behavior

2020-09-04T10:27:33Z

Without the casts the bytes accesses get converted to int. but int is not guaranteed to be 4 bytes large. Even when it is 4 bytes large `bytes[3] << 24` does not fit because int is signed. Signed-off-by: Valentin Kettner

Use fixed size integer type

2020-09-04T10:27:23Z

This type is meant to be 4 bytes large as seen in _XcursorReadUInt which always reads 4 bytes. An unsigned int is often 4 bytes large but this isnt' guaranteed so it is cleaner to use the exact type we want. Signed-off-by: Valentin Kettner

cursor: Properly document wl_cursor_image and wl_cursor

2020-06-05T11:05:20Z

Signed-off-by: Emmanuel Gil Peyrot

cursor: Use spaces for alignment in the header

2020-06-05T11:05:20Z

Signed-off-by: Emmanuel Gil Peyrot

cursor/os-compatibility: move resizing into a separate function

2020-02-23T20:42:54Z

Signed-off-by: Jan Beich

cursor: ignore posix_fallocate in shm_pool_resize if not supported by FS

2020-02-23T20:42:54Z

Signed-off-by: Jan Beich

cursor: posix_fallocate may fail with EINVAL if not supported

2020-02-23T20:42:54Z

ZFS on FreeBSD >= 12.0 returns EINVAL, see https://svnweb.freebsd.org/changeset/base/325320 Signed-off-by: Jan Beich

os: fallback for unsupported posix_fallocate

2020-01-23T20:32:59Z

Some filesystems do not support fallocate and return EOPNOTSUPP. On musl-based distros libwayland-cursor exits abruptly which causes the application to crash. Unlike glibc, musl does not provide a fallback mechanism for handling unsupported fallocate. Instead, musl developers argue that application should handle the case of unsupported system call. This commit allows falback to ftruncate in case when EOPNOTSUPP was recieved. Signed-off-by: Ihor Antonov

Add Meson build

2020-01-10T22:44:38Z

Meson is a next generation build system, simpler than Autotools and also faster and more portable. Most importantly, it will make integrating ASan easier in CI. The goal is to maintain feature parity of the Meson build with the Autotools build, until such time when we can drop the latter. Add a script which generates the desired Doxygen configuration for our various output formats and executes it using that configuration. This is not something Meson can or should do. Fixes: https://gitlab.freedesktop.org/wayland/wayland/issues/80 [daniels: Changed to bump version, use GitLab issues URL, remove header checks not used in any code, remove pre-pkg-config Expat support, added missing include paths to wayland-egl and cpp-compile-test, added GitLab CI. Bumped version, removed unnecessary pkg-config paths.] [daniels: Properly install into mandir/man3 via some gross paramaterisation, generate real stamp files.] Pekka: - squashed patches - removed MAKEFLAGS from meson CI - remove unused PACKAGE* defines - fix up scanner dependency handling - instead of host_scanner option, build wayland-scanner twice when cross-compiling - changed .pc files to match more closely the autotools versions - reorder doxygen man sources to reduce diff to autotools - fix pkgconfig.generate syntax warnings (new in Meson) - bump meson version to 0.47 for configure_file(copy) and run_command(check) - move doc tool checks into doc/meson.build, needed in more places - make all doc tools mandatory if building docs - check dot and doxygen versions - add build files under doc/publican - reindent to match Weston Meson style Simon: - Remove install arg from configure_file - Don't build wayland-scanner twice during cross-build - Fix naming of the threads dependency - Store tests in dict - Add missing HAVE_* decls for functions - Remove unused cc_native variable - Make doxygen targets a dict - Make dot_gv a dict - Use dicts in man_pages - Make decls use dicts - Make generated_headers use dicts - Align Meson version number with autotool's Signed-off-by: Pekka Paalanen Signed-off-by: Simon Ser

cursor: Use memfd_create() when available

2019-07-21T09:06:43Z

This (so-far) Linux-only API lets users create file descriptors purely in memory, without any backing file on the filesystem and the race condition which could ensue when unlink()ing it. It also allows seals to be placed on the file, ensuring to every other process that we won’t be allowed to shrink the contents, potentially causing a SIGBUS when they try reading it. This patch is best viewed with the -w option of git log -p. Signed-off-by: Emmanuel Gil Peyrot Reviewed-by: Simon Ser

cursor: add forward declaration for struct wl_buffer

2017-12-04T19:45:38Z

This makes the header self-contained, since the struct is considered opaque from waylad-cursor POV. As we're here move the wl_shm fwd. declaration alongside the others. Making it easier to read and track. Signed-off-by: Emil Velikov Reviewed-by: Yong Bakos

cursor: Fix heap overflows when parsing malicious files.

2017-11-29T07:45:10Z

It is possible to trigger heap overflows due to an integer overflow while parsing images. The integer overflow occurs because the chosen limit 0x10000 for dimensions is too large for 32 bit systems, because each pixel takes 4 bytes. Properly chosen values allow an overflow which in turn will lead to less allocated memory than needed for subsequent reads. See also: https://cgit.freedesktop.org/xorg/lib/libXcursor/commit/?id=4794b5dd34688158fb51a2943032569d3780c4b8 Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=103961 Signed-off-by: Tobias Stoeckmann [Pekka: add link to the corresponding libXcursor commit] Signed-off-by: Pekka Paalanen

cursor: Remove "weston" from anonymous shm filenames

2016-11-21T09:58:25Z

This mildly confused me during some debugging, so I guess it wouldn't hurt to make the filename more indicative of where it was actually created. Signed-off-by: Derek Foreman Reviewed-by: Yong Bakos Reviewed-by: Giulio Camuffo Reviewed-by: Daniel Stone

(multiple): Include stdint.h

2016-07-26T01:39:32Z

Some headers and source files have been using types such as uint32_t without explicitly including stdint.h. Explicitly include stdint.h where appropriate. Signed-off-by: Yong Bakos Reviewed-by: Eric Engestrom

cursor: Update printed license from MIT "X11" to MIT "Expat"

2015-06-22T11:50:20Z

The code generates a cursor-data.h file, with licensing information. Change this from the MIT "X11" license to MIT "Expat" license for consistency with the rest of Wayland. Signed-off-by: Bryce Harrington Reviewed-by: Pekka Paalanen

xcursor: Change keithp licensed code from X11 to Expat license

2015-06-12T22:51:38Z

The license text for this file mentions Keith Packard specifically, however it is otherwise identical to all the other MIT X11 licensed code in Wayland, and so can be changed to the substantially identical MIT Expat license. Signed-off-by: Bryce Harrington Reviewed-by: Pekka Paalanen Acked-by: Keith Packard

cursor-data.h: Change SuSE licensed code from X11 to Expat

2015-06-12T22:51:38Z

The license text for this file mentions SuSE specifically, however it is otherwise identical to all the other MIT X11 licensed code in Wayland, and so can be changed to the substantially identical MIT Expat license. Signed-off-by: Bryce Harrington Reviewed-by: Pekka Paalanen Acked-by: Keith Packard

cursor: Update boilerplate from MIT X11 license to MIT Expat license

2015-06-12T22:51:38Z

Signed-off-by: Bryce Harrington Reviewed-by: Pekka Paalanen

remove trailing whitespaces

2015-05-15T20:10:15Z

Remove trailing whitespaces because they are not needed and jumping to the end of al ine should do just that and not jump to the whitespace.

cursor: free the array from which images are linked

2015-03-18T23:01:19Z

cursor: add wl_cursor_frame_and_duration

2015-03-05T07:39:44Z

It's useful to know how long the current cursor frame should be displayed so we can wait that long to change it. Signed-off-by: Derek Foreman Reviewed-by: Pekka Paalanen

Add error handling for wl_cursors

2014-04-01T23:47:04Z

This patch adds some error management in wayland cursors Reviewed-by: Bryce Harrington

build: Move cursor Makefile.am into toplevel Makefile.am

2014-03-07T07:15:02Z

xcursor: don't proceed if XcursorImageCreate failed

2014-01-15T18:46:09Z

Signed-off-by: U. Artie Eoff

cursor: check for memory allocation errors

2014-01-15T18:46:09Z

Signed-off-by: U. Artie Eoff

cursor: free theme->name too

2014-01-15T18:46:09Z

Signed-off-by: U. Artie Eoff

cursor: handle running out of buffer space

2013-12-03T00:19:45Z

If posix_fallocate is available, use it to detect when we are running out of buffer space. Propagate the failure properly through the various functions, stopping loading cursors but keeping the cursors that were already successfully loaded. This may result in an animated cursor not having all of its images, or a cursor theme not having all of its cursors. When that happens, the failure is NOT communicated to the application. Instead, the application will get NULL from wl_cursor_theme_get_cursor() for a cursor that was not loaded successfully. If an animated cursor is missing only some images, the animation is truncated but the cursor is still available. This patch relies on the commit "os: use posix_fallocate in creating sharable buffers" for defining HAVE_POSIX_FALLOCATE. Signed-off-by: Pekka Paalanen

os: use posix_fallocate in creating sharable buffers

2013-12-03T00:18:59Z

If posix_fallocate is available, use it instead of ftruncate. Unlike ftruncate, when posix_fallocate succeeds, it guarantees that you cannot run out of disk space, when later writing to the mmap()'ed file. With posix_fallocate, if os_create_anonymous_file() succeeds, the program cannot get a SIGBUS later from accessing this file via mmap. If there is insufficient disk space, the function fails and errno is set to ENOSPC. This is useful on systems, that limit the available buffer space by having XDG_RUNTIME_DIR on a small tmpfs. Signed-off-by: Pekka Paalanen

wayland: Be consistent about #include-guard names

2013-10-21T21:39:06Z

We had a mix of inconsistent names, some of which were non-conformant. Standardize on all-uppercase-and-underscore naming convention. https://bugs.freedesktop.org/show_bug.cgi?id=70679

pkgconfig: Use configure provided directories

2012-11-28T01:35:50Z

https://bugs.freedesktop.org/show_bug.cgi?id=57630

Move ARRAY_LENGTH out of public headers

2012-10-19T21:08:38Z

Exporting unprefixed symbols is a pretty bad idea so don't do that. Instea of redefining it WL_ARRAY_LENGTH, we just move the define to our private header. The scanner generates code that uses ARRAY_LENGTH, but we can just make it count the number elements and emit an integer constant instead.

Ensure cursor_data.c is included in distribution tarballs

2012-10-10T03:42:52Z

Signed-off-by: Matt Roper

xcursor: Fix allocation based on string length

2012-10-10T03:01:23Z

strlen() doesn't include the terminating NUL. Therefore when allocating a block of memory to hold something equivalent to the length of the string we must increment to take the NUL byte into consideration. Signed-off-by: Rob Bradford

cursor: add cursor.pcf and extraction program

2012-09-11T01:05:14Z

cursor: Add a default cursor theme

2012-09-11T01:04:55Z

This theme is loaded when the specified cursor theme can not be found. These cursors are extracted from the xorg sources and transformed into raw ARGB data by a small helper program (commited separately).

Add support for X cursor themes.

2012-08-13T15:02:56Z

This patch adds a few more directories to search for xcursor themes. Along with the weston patch, this adds the ability to configure weston to use an X11 cursor theme. Previously, wayland cursor would just look in the icons and pixmaps directories for cursor images to load. This adds the ability to also search in the x cursors directory.

Don't skip the first directory entry when reading cursors.

2012-07-27T02:04:32Z

I end up missing the "bottom_right_corner" cursor.

cursor: fix fd leak and a segfault

2012-07-10T18:11:00Z

- don't leak fd in shm_pool_destroy() - return NULL from wl_cursor_theme_load() if pool fails Tha last one fixes a segfault, when shm_pool_create() has failed. Signed-off-by: Pekka Paalanen

cursor: use os_create_anonymous_file()

2012-07-10T18:08:59Z

Copy the implementation of os_create_anonymous_file() here from weston, so we can use it instead of hardcoding a path to /tmp. Signed-off-by: Pekka Paalanen